The user entry in the configuration file is currently not used correctly. It is used to both:
- find the user branch to checkout from SVN
- set the email address for the PBS script
The email address should use the user ID of the user that is running benchcab and this info can be obtained from the environment variables.
But the user ID for the branch should not be tied up to the user running benchcab. This would allow anyone to run benchcab on anyone's branch. So should the user entry be under the realisation entry and be optional (not needed for trunk)?
But, currently we give the branch name after branches/Users/{user-id} so we have to distinguish 3 cases:
- user branches
- share branches (under branches/Share)
- trunk (under trunk)
What if we changed to give the name of the branch from the root of the SVN repository so we don't have to bother with different cases? That means we would give the names as:
trunk for the trunk
branches/Share/<branch_name> for shared branch
branches/Users/<u_id>/<branch_name> for user branches
That's longer for the user to enter but that's a simply copy paste from the URL, so maybe it's not too onerous. This way, we can remove the following entries from realisation in config.yaml:
The
userentry in the configuration file is currently not used correctly. It is used to both:The email address should use the user ID of the user that is running
benchcaband this info can be obtained from the environment variables.But the user ID for the branch should not be tied up to the user running
benchcab. This would allow anyone to runbenchcabon anyone's branch. So should the user entry be under therealisationentry and be optional (not needed for trunk)?But, currently we give the branch name after
branches/Users/{user-id}so we have to distinguish 3 cases:What if we changed to give the name of the branch from the root of the SVN repository so we don't have to bother with different cases? That means we would give the names as:
trunkfor the trunkbranches/Share/<branch_name>for shared branchbranches/Users/<u_id>/<branch_name>for user branchesThat's longer for the user to enter but that's a simply copy paste from the URL, so maybe it's not too onerous. This way, we can remove the following entries from
realisationin config.yaml: