From d44d90dba7ce77a866da4f40454a2480237f8764 Mon Sep 17 00:00:00 2001 From: John McLaren Date: Tue, 22 Sep 2026 14:28:55 +0000 Subject: [PATCH 1/2] fix(ci): desktop artifact builds no longer fail on a placeholder allowBuilds entry Every Desktop Artifacts leg died in readWorkspaceConfig with "SchemaError: Expected boolean at allowBuilds.msgpackr-extract": pnpm-workspace.yaml carried `msgpackr-extract: set this to true or false`, an unfilled placeholder from the upstream Effect rc.115 dependency bump. pnpm tolerates the string, so CI stayed green, but build-desktop-artifact.ts decodes allowBuilds as a boolean record. Nothing in the lockfile references msgpackr-extract and upstream main has since dropped the line, so delete it and record the repair in FORK.md entry 14. Co-Authored-By: Claude Fable 5.1 Claude-Session: https://claude.ai/code/session_01J6iMDRM6VXUTNdZxk9aJDt --- FORK.md | 11 +++++++++-- pnpm-workspace.yaml | 1 - 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/FORK.md b/FORK.md index 6ad4bcce773f..dfe5f695d642 100644 --- a/FORK.md +++ b/FORK.md @@ -15,8 +15,8 @@ support (15, 19), a configurable worktree branch prefix (17), upstream's provide limits surfaced in the model picker and context bubble (22, web-only), and three web UX changes (5, 6, 18). Everything else is byte-identical to upstream — `native/`, `scripts/` (one orphaned release script deleted aside, entry 14), `apps/desktop/`, `packages/client-runtime/` -(one test fixture aside), `apps/server/src/persistence/`, `pnpm-lock.yaml` and -`pnpm-workspace.yaml` are untouched, and the only edits under `infra/` and `packaging/` are the +(one test fixture aside), `apps/server/src/persistence/` and `pnpm-lock.yaml` are untouched, +`pnpm-workspace.yaml` differs by one deleted placeholder line (entry 14), and the only edits under `infra/` and `packaging/` are the entry 14 notes explaining which workflow no longer runs them. Mobile carries entry 19's usage screens and nothing else. @@ -247,6 +247,13 @@ intent against current upstream code, taking upstream's version of anything that #12417) — no flag, env or job-shape change, so `desktop-artifacts.yml` needed nothing. No new upstream workflow this range. `grep -rn blacksmith .github/workflows/` still matches only the explanatory comment in `desktop-artifacts.yml`. +- **Repaired in place at `7a32d882`.** `d547e3b1` (#12326) landed `pnpm-workspace.yaml` with + `msgpackr-extract: set this to true or false` under `allowBuilds`, an unfilled placeholder: + pnpm tolerates it and `ci.yml` stayed green, but `build-desktop-artifact.ts` decodes + `allowBuilds` as a boolean record, so every Desktop Artifacts leg failed on `SchemaError: + Expected boolean`. Nothing in `pnpm-lock.yaml` references that package, and upstream's current + `main` no longer carries the line, so the fork deletes it. Take upstream's file on the next + sync; this is not a fork change to keep. ### 15. A logged-out Claude instance reports as unauthenticated, and shows the directory it resolved diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml index 0b4e86c2d5dd..7c7106bd7637 100644 --- a/pnpm-workspace.yaml +++ b/pnpm-workspace.yaml @@ -15,7 +15,6 @@ allowBuilds: electron: true electron-winstaller: false esbuild: true - msgpackr-extract: set this to true or false msw: false node-pty: true sharp: true From f108e5b37538687c509ce8670e19e0898862e849 Mon Sep 17 00:00:00 2001 From: John McLaren Date: Tue, 22 Sep 2026 14:31:31 +0000 Subject: [PATCH 2/2] fix(ci): reflow the FORK.md note so the formatter check passes Co-Authored-By: Claude Fable 5.1 Claude-Session: https://claude.ai/code/session_01J6iMDRM6VXUTNdZxk9aJDt --- FORK.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/FORK.md b/FORK.md index dfe5f695d642..2e01c73a9eda 100644 --- a/FORK.md +++ b/FORK.md @@ -250,10 +250,10 @@ intent against current upstream code, taking upstream's version of anything that - **Repaired in place at `7a32d882`.** `d547e3b1` (#12326) landed `pnpm-workspace.yaml` with `msgpackr-extract: set this to true or false` under `allowBuilds`, an unfilled placeholder: pnpm tolerates it and `ci.yml` stayed green, but `build-desktop-artifact.ts` decodes - `allowBuilds` as a boolean record, so every Desktop Artifacts leg failed on `SchemaError: - Expected boolean`. Nothing in `pnpm-lock.yaml` references that package, and upstream's current - `main` no longer carries the line, so the fork deletes it. Take upstream's file on the next - sync; this is not a fork change to keep. + `allowBuilds` as a boolean record, so every Desktop Artifacts leg failed on + `SchemaError: Expected boolean`. Nothing in `pnpm-lock.yaml` references that package, and + upstream's current `main` no longer carries the line, so the fork deletes it. Take upstream's + file on the next sync; this is not a fork change to keep. ### 15. A logged-out Claude instance reports as unauthenticated, and shows the directory it resolved