Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overall column and have Study labels horisontally #132

Closed
henda52 opened this issue Dec 2, 2021 · 6 comments
Closed

Remove overall column and have Study labels horisontally #132

henda52 opened this issue Dec 2, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@henda52
Copy link

henda52 commented Dec 2, 2021

Thanks for a great tool!

I'm making a traffic light summary of a ROB tool that is not in your templates. It has 10 different ROB estimates and no overall judgment. There are 49 studies.

As I understand it, I have to use the tool = "ROB1" setting because it doesn't fit with the other templates. However, for this template, the overall= FALSE setting is not available (I get unused argument when I try to use that). My workaround is to create an overall column in the dataset and ignore it in the produced figure (or crop it in a software).

Is there a way to remove the overall column in this case?

Another problem is that the Study labels are written vertically and the does not fit within the small grey box so they are unreadable. Is there a way to make the Study label box larger so that the name of the study is visible?

Here is a minimal reproducible example

df <- dplyr::bind_rows(data_rob1, data_rob1, data_rob1, data_rob1, data_rob1)
df$Study <- paste0("Study ", seq.int(from = 1, to =45))
df %>%
robvis::rob_traffic_light(tool = "ROB1", colour = "cochrane", psize = 5)

@henda52 henda52 added the enhancement New feature or request label Dec 2, 2021
@mcguinlu
Copy link
Owner

mcguinlu commented Dec 2, 2021

Hi @henda52 - thanks for your message.

For the vertical study label issue, see here: #81

Unfortunately, I am in the last couple of weeks of my PhD and so won't have a chance to look at the overall column issue before Christmas. There is a load of new functionality coming to robvis in the New Year though, so I'll add this to the list of things to address as part of that overhaul!

@henda52
Copy link
Author

henda52 commented Dec 2, 2021

Thanks so much!
The update helped. Looking forward to the new version next year.
Good luck with the Phd!

@Rmadillo
Copy link

Hi Luke! Thanks for an awesome tool!!!

I have the same issue as @henda52 in that I don't have an overall column and wondering if you'd had a chance to work on this aspect of it for ROB1/Generic, i.e., an overall = F. I can see it works in the webapp, but when you uncheck Overall column in the webapp, the legend and caption overwrite each other when you download the image.

@mcguinlu
Copy link
Owner

mcguinlu commented Jun 7, 2023

Hey @Rmadillo @henda52 - just a heads up that the development version of robvis now supports this functionality (also discussed in #123).

Install/update to the new development version by running:

install.packages("devtools")
devtools::install_github("mcguinlu/robvis")

As an illustration, the following code:

robvis::rob_traffic_light(
  data_rob1[1:8],
  tool = "Generic",
  overall = FALSE
)

will now produce the image below, with the expected behaviour for overall = FALSE:

Rplot01

@Rmadillo
Copy link

Rmadillo commented Jun 10, 2023 via email

@henda52
Copy link
Author

henda52 commented Jun 11, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants