add psalm

Author: mmoll

.travis.yml

@@ -31,6 +31,7 @@ script:
   - vendor/bin/phpunit # Run tests
   - vendor/bin/phpcs # Stylecheck against PHPCS's ruleset
   - vendor/bin/phpstan analyse --no-progress # Run PHPStan
+  - vendor/bin/psalm --show-info=false # run psalm
   - if [ "${DEPENDENCIES}" = "highest" ]; then vendor/bin/phan -i; fi; # Run phan
   - if [ "${TRAVIS_PHP_VERSION}" != "7.3" ]; then php -d zend_extension=xdebug.so vendor/bin/phpunit --coverage-clover=coverage.xml; fi; # Generate Code coverage report
 

MO4/Sniffs/Arrays/ArrayDoubleArrowAlignmentSniff.php

@@ -60,6 +60,8 @@ public function register(): array
      *                        the stack passed in $tokens.
      *
      * @return void
+     *
+     * @psalm-suppress LoopInvalidation
      */
     public function process(File $phpcsFile, $stackPtr): void
     {

MO4/Sniffs/Formatting/UnnecessaryNamespaceUsageSniff.php

@@ -160,13 +160,17 @@ public function process(File $phpcsFile, $stackPtr): void
                         $docCommentTags[$content]
                     );
                     // phpcs:enable
+
                     foreach ($docLineTokens as $docLineToken) {
+                        // phpcs:disable
+                        /** @var array<string> $typeTokens */
                         $typeTokens = PregLibrary::mo4_preg_split(
                             '/\|/',
                             $docLineToken,
                             -1,
                             PREG_SPLIT_NO_EMPTY
                         );
+                        // phpcs:enable
 
                         foreach ($typeTokens as $typeToken) {
                             if (\in_array($typeToken, $useStatements, true) === true) {
@@ -348,7 +352,7 @@ private function checkShorthandPossible(
         $code    = 'UnnecessaryNamespaceUsage';
         $fixable = false;
         $replaceClassName = false;
-        $replacement      = null;
+        $replacement      = '';
 
         $fullClassName = $this->getFullyQualifiedClassName($className);
 

composer.json

@@ -26,7 +26,8 @@
         "phpstan/phpdoc-parser": "^0.4.1",
         "phpstan/phpstan": "^0.12.2",
         "phpstan/phpstan-strict-rules": "^0.12",
-        "phpunit/phpunit": "^7.0"
+        "phpunit/phpunit": "^7.0",
+        "vimeo/psalm": "^3.8"
     },
     "require": {
         "php": "~7.1",

psalm.xml

@@ -0,0 +1,24 @@
+<?xml version="1.0"?>
+<psalm
+    totallyTyped="false"
+    resolveFromConfigFile="true"
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xmlns="https://getpsalm.org/schema/config"
+    xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
+    autoloader="tests/bootstrap.php"
+>
+    <projectFiles>
+        <directory name="MO4" />
+        <ignoreFiles>
+            <directory name="vendor" />
+            <directory name="integrationtests" />
+        </ignoreFiles>
+    </projectFiles>
+
+    <issueHandlers>
+        <PropertyNotSetInConstructor errorLevel="info" />
+        <MissingConstructor errorLevel="info" />
+
+        <UndefinedClass errorLevel="info" /> <!-- somehow this is showing up in travis -->
+    </issueHandlers>
+</psalm>