Skip to content

[DE-1103] Fix idle connection timeout in tests #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maciej-nedza merged 1 commit into from
Jan 30, 2025
Merged

[DE-1103] Fix idle connection timeout in tests #198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/src/test/java/com/maxio/advancedbilling/TestClientProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.maxio.advancedbilling;

import com.maxio.advancedbilling.authentication.BasicAuthModel;
import okhttp3.OkHttpClient;

import java.util.ArrayList;
import java.util.List;
Expand Down Expand Up @@ -67,7 +68,11 @@ public static String getEnvValue(String key) {

private static AdvancedBillingClient createClient(String subdomain, String apiKey) {
return new AdvancedBillingClient.Builder()
.httpClientConfig(configBuilder -> configBuilder.timeout(45))
.httpClientConfig(configBuilder -> configBuilder
.timeout(45)
.httpClientInstance(
new OkHttpClient.Builder().retryOnConnectionFailure(true).build()
))
.basicAuthCredentials(
new BasicAuthModel.Builder(apiKey, PASSWORD)
.build())
Expand Down
4 changes: 0 additions & 4 deletions tests/src/test/java/com/maxio/advancedbilling/controllers/sites/SitesControllerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ class SitesControllerTest {
@Test
void shouldReadSite() throws Exception {
// when
// bug: idle connection can be closed.
try {
Site site = sitesController.readSite().getSite();
} catch (Exception ignored) {}
Site site = sitesController.readSite().getSite();

// then
Expand Down