From 788039da2b1995a6a6cdfafb2015801c08627eb0 Mon Sep 17 00:00:00 2001 From: Maciej Nedza Date: Thu, 30 Jan 2025 10:30:18 +0100 Subject: [PATCH] [DE-1103] Fix idle connection timeout in tests --- .../java/com/maxio/advancedbilling/TestClientProvider.java | 7 ++++++- .../controllers/sites/SitesControllerTest.java | 4 ---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/src/test/java/com/maxio/advancedbilling/TestClientProvider.java b/tests/src/test/java/com/maxio/advancedbilling/TestClientProvider.java index c0311ff8..fbb14659 100644 --- a/tests/src/test/java/com/maxio/advancedbilling/TestClientProvider.java +++ b/tests/src/test/java/com/maxio/advancedbilling/TestClientProvider.java @@ -1,6 +1,7 @@ package com.maxio.advancedbilling; import com.maxio.advancedbilling.authentication.BasicAuthModel; +import okhttp3.OkHttpClient; import java.util.ArrayList; import java.util.List; @@ -67,7 +68,11 @@ public static String getEnvValue(String key) { private static AdvancedBillingClient createClient(String subdomain, String apiKey) { return new AdvancedBillingClient.Builder() - .httpClientConfig(configBuilder -> configBuilder.timeout(45)) + .httpClientConfig(configBuilder -> configBuilder + .timeout(45) + .httpClientInstance( + new OkHttpClient.Builder().retryOnConnectionFailure(true).build() + )) .basicAuthCredentials( new BasicAuthModel.Builder(apiKey, PASSWORD) .build()) diff --git a/tests/src/test/java/com/maxio/advancedbilling/controllers/sites/SitesControllerTest.java b/tests/src/test/java/com/maxio/advancedbilling/controllers/sites/SitesControllerTest.java index f99cffe2..6726110a 100644 --- a/tests/src/test/java/com/maxio/advancedbilling/controllers/sites/SitesControllerTest.java +++ b/tests/src/test/java/com/maxio/advancedbilling/controllers/sites/SitesControllerTest.java @@ -23,10 +23,6 @@ class SitesControllerTest { @Test void shouldReadSite() throws Exception { // when - // bug: idle connection can be closed. - try { - Site site = sitesController.readSite().getSite(); - } catch (Exception ignored) {} Site site = sitesController.readSite().getSite(); // then