-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing issue with Swift 6.0 and DateEncodingStrategy #8
Conversation
The failing CI for the bionic and amazonlinux containers for Swift 5.8 and 5.9 at least are known issues — we can just remove those specific entries from the test matrix. |
I added an XCTSkip since we can run those tests in Linux |
I'm not totally clear on why Swift 6 on Linux stopped being able to support some of the test cases that earlier Swift versions supported on Linux but ideally the tests would only be skipped for the specific Linux test runs where they are expected to fail so we don't introduce regressions for support of Linux with Swift versions prior to 6 by accident. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was about to do the same changes but thanks for opening this up. I do wonder too why that got removed in 6.0. 🤔
It looks like Swift 6.0 removed the
DateEncodingStrategy.formatted(_)
case. This patches that and adds CI runs for newer versions of Ubuntu and Swift.