Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue with Swift 6.0 and DateEncodingStrategy #8

Merged
merged 11 commits into from
Oct 1, 2024

Conversation

leogdion
Copy link
Contributor

It looks like Swift 6.0 removed the DateEncodingStrategy.formatted(_) case. This patches that and adds CI runs for newer versions of Ubuntu and Swift.

@mattpolzin
Copy link
Owner

mattpolzin commented Sep 18, 2024

The failing CI for the bionic and amazonlinux containers for Swift 5.8 and 5.9 at least are known issues — we can just remove those specific entries from the test matrix.
[EDIT] apparently that’s the same issue even for 5.10 and 6.0 for the amazonlinux containers. Remove those too. Not worth testing against them if it’s going to be a pain.

@leogdion
Copy link
Contributor Author

I added an XCTSkip since we can run those tests in Linux

@mattpolzin
Copy link
Owner

I'm not totally clear on why Swift 6 on Linux stopped being able to support some of the test cases that earlier Swift versions supported on Linux but ideally the tests would only be skipped for the specific Linux test runs where they are expected to fail so we don't introduce regressions for support of Linux with Swift versions prior to 6 by accident.

Copy link

@jcbriones jcbriones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to do the same changes but thanks for opening this up. I do wonder too why that got removed in 6.0. 🤔

@mattpolzin mattpolzin merged commit 4abc8cf into mattpolzin:main Oct 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants