refactor: only ask the rpc if everything fails

Author: fborello-lambda

store/zksync/tokens.ts

@@ -61,27 +61,23 @@ export const useZkSyncTokensStore = defineStore("zkSyncTokens", () => {
     }
 
     const btL1Address = await provider.getBaseTokenContractAddress();
-    if (btL1Address !== utils.ETH_ADDRESS) {
+    if (btL1Address !== utils.ETH_ADDRESS && !baseToken) {
       const l1Rpc = useNetworkStore();
       const l1Provider = new ethers.providers.JsonRpcProvider(l1Rpc.l1Network?.rpcUrls.default.http[0]);
       const walletEthers = ethers.Wallet.createRandom();
       const connectedWallet = walletEthers.connect(l1Provider);
       const ERC20_L1 = new ethers.Contract(btL1Address, IERC20, connectedWallet);
       const ERC20_SYMBOL: string = (await ERC20_L1.symbol()) || "BT";
       const ERC20_DECIMALS = (await ERC20_L1.decimals()) || 18;
-      if (!baseToken) {
-        baseToken = {
-          address: L2_BASE_TOKEN_ADDRESS,
-          l1Address: btL1Address,
-          symbol: ERC20_SYMBOL,
-          name: ERC20_SYMBOL,
-          decimals: ERC20_DECIMALS,
-          iconUrl: "/img/era.svg",
-        };
-      }
-    }
-
-    if (!baseToken) {
+      baseToken = {
+        address: L2_BASE_TOKEN_ADDRESS,
+        l1Address: btL1Address,
+        symbol: ERC20_SYMBOL,
+        name: ERC20_SYMBOL,
+        decimals: ERC20_DECIMALS,
+        iconUrl: "/img/era.svg",
+      };
+    } else {
       baseToken = ethToken;
     }