-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn print statements into logging #27
Comments
Thanks! Just wait a bit, I need to take a look at this PR first #24 (I haven't had time to work on this PR for a long time, though...) Once that is done, please make a PR! As I'd like to keep this repository as simple as possible, very simple logging is appreciated :) |
Thanks for the response, I'll wait! If you want, you can ping me when this can be started. |
@stephantul Sorry for the super long delay... Now you can start 👍 |
If this is still open can I work on this? |
@DivyanshVinayak23 Sure, I totally forgot to pick this up. (@matsui528 my apologies 🙏 ) |
@DivyanshVinayak23 @stephantul Thanks! Please go ahead 👍 |
Hi!
Thanks for writing this package, it looks great!
I'd be interested in turning the print statements (with verbose=True) into logging statements. The verbose flag could then be used to control whether this logging is output to stdout (i.e., by setting the log level). Is this something you are interested in? if so, I could submit a PR.
The text was updated successfully, but these errors were encountered: