Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgres backend schema management in the appservice #415

Open
Gnuxie opened this issue Nov 9, 2022 · 2 comments · May be fixed by #437
Open

Postgres backend schema management in the appservice #415

Gnuxie opened this issue Nov 9, 2022 · 2 comments · May be fixed by #437
Labels
A-Appservice T-Task Refactoring, enabling or disabling functionality, other engineering tasks X-Release-Blocker This issue must be resolved before the next release can be made

Comments

@Gnuxie
Copy link
Contributor

Gnuxie commented Nov 9, 2022 •
edited
Loading

Currently we create tables adhoc

mjolnir/mx-tester.yml

Line 9 in ec4cb2e

- psql postgres://mjolnir-tester:mjolnir-test@localhost:8083/mjolnir-test-db -c "CREATE TABLE mjolnir (local_part VARCHAR(255), owner VARCHAR(255), management_room TEXT)"

We could potentially rely on matrix-org/matrix-appservice-bridge#442 for this, but we could handle it ourselves if review is taking too long. This is the same pattern used by the other bridges and can be copied pretty closely.
@Gnuxie Gnuxie added T-Task Refactoring, enabling or disabling functionality, other engineering tasks A-Appservice X-Release-Blocker This issue must be resolved before the next release can be made labels Nov 9, 2022
@Gnuxie Gnuxie mentioned this issue Nov 9, 2022
Merged
@Gnuxie
Copy link
Contributor Author

Gnuxie commented Nov 10, 2022

#364 (comment)

@Gnuxie Gnuxie mentioned this issue Nov 15, 2022
Open
@Yoric
Copy link
Contributor

Yoric commented Nov 21, 2022

matrix-org/matrix-appservice-bridge#442 seems to have been merged \o/

@Gnuxie Gnuxie linked a pull request Nov 25, 2022 that will close this issue
Open
@Gnuxie Gnuxie mentioned this issue Dec 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Appservice T-Task Refactoring, enabling or disabling functionality, other engineering tasks X-Release-Blocker This issue must be resolved before the next release can be made
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use matrix-appservice-bridge's new PostgreSQL datastore. matrix-org/mjolnir
2 participants
@Yoric @Gnuxie