Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Totals row should show filtered totals #21814

Open
4 tasks done
pbb72 opened this issue Jan 16, 2024 · 10 comments · May be fixed by #22895
Open
4 tasks done

[Bug] Totals row should show filtered totals #21814

pbb72 opened this issue Jan 16, 2024 · 10 comments · May be fixed by #22895
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. triaged

Comments

@pbb72
Copy link

pbb72 commented Jan 16, 2024

What happened?

When the Search function (which is not a search function at all, but a filter function) is used on a table to only show certain rows, the totals row still shows the totals over all rows.

What should happen?

Either the totals row should show the totals for only the filtered data, or another row should be added to show the totals for only the filtered data.

How can this be reproduced?

Go to any table that supports both Search (ie, filter) and Show Totals Row. Enter a filter value, and see that the totals aren't updated.

Matomo version

4.13.3

PHP version

No response

Server operating system

No response

What browsers are you seeing the problem on?

No response

Computer operating system

No response

Relevant log output

No response

Validations

@pbb72 pbb72 added Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Jan 16, 2024
@bx80
Copy link
Contributor

bx80 commented Jan 19, 2024

Thanks for reporting this @pbb72 👍

It would certainly be better if the totals row correctly reflected the displayed rows. I'll pass this on to our product team for prioritization.

@bx80 bx80 added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. To Triage An issue awaiting triage by a Matomo core team member labels Jan 19, 2024
@bx80 bx80 added this to the For Prioritization milestone Jan 19, 2024
@atom-box
Copy link
Contributor

atom-box commented Feb 2, 2024

Another user asked for this also:

Feature: Pages
Like: No
Feedback:
If I filter the table data via the search input at the bottom of the table the row containing the totals does not update accordingly to the entered query and still show the totals of all pages.
Please also note, that the feature "Aggregated rows are displayed" is activated.
Thoose values should be excluded from the totals, otherwise this data would be counted twice.
By the way: it seems to be a general problem not only for page views.

@bojana-z
Copy link

bojana-z commented Feb 8, 2024

Another user is facing a similar issue. When the report is flattened, the totals are not refreshed in dashboard; it shows the total for the hierarchical report. You need to export the flattened report and summarize the values to see the correct totals.

@tsteur tsteur added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. and removed Bug For errors / faults / flaws / inconsistencies etc. labels Feb 20, 2024
@tsteur
Copy link
Member

tsteur commented Feb 20, 2024

Either the totals row should show the totals for only the filtered data, or another row should be added to show the totals for only the filtered data.

It's expected behaviour for the totals row to show the sum of all rows. We would need to add another second row that shows the totals for the matched rows.

@pbb72
Copy link
Author

pbb72 commented Feb 21, 2024

It's expected behaviour [...]

You state that as if you know every user? I definitely didn't expect this behaviour, otherwise I wouldn't have submitted this bug. Did you mean "intended behaviour" or am I misunderstanding?

@tsteur
Copy link
Member

tsteur commented Feb 21, 2024

@pbb72 Yes, I meant "intended behaviour" 👍 Sorry for the confusion.

@pbb72
Copy link
Author

pbb72 commented Feb 27, 2024

Then I think the intended behaviour is wrong (obviously, as I posted this bug report). I still feel a single totals row that displays the totals of the filtered results would be the expected result for most users.

But I guess having two totals rows would be the best of both worlds.

@Chardonneaur
Copy link
Contributor

I got a client asking for this today.

@randy-innocraft randy-innocraft added Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. and removed Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. labels May 16, 2024
@atom-box
Copy link
Contributor

We had a user get majorly tripped up by this today.

They have been exporting what they thought was a subset, and reporting to their client a falsely high total because of this bug.

@Chardonneaur
Copy link
Contributor

I got a client asking for this feature today.

@innocraft-automation innocraft-automation removed this from the Backlog (Help wanted) milestone Sep 13, 2024
@sgiehl sgiehl linked a pull request Jan 14, 2025 that will close this issue
11 tasks
@sgiehl sgiehl marked this as a duplicate of #23082 Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants