Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only admins should disconnect DBs #4007

Open
mathemancer opened this issue Nov 4, 2024 · 0 comments · May be fixed by #4024
Open

Only admins should disconnect DBs #4007

mathemancer opened this issue Nov 4, 2024 · 0 comments · May be fixed by #4024
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation type: bug Something isn't working work: backend Related to Python, Django, and simple SQL
Milestone
v0.2.0 (beta rele...

Comments

@mathemancer
Copy link
Contributor

Description

Any user can make an RPC call to databases.configured.disconnect, meaning any user can disconnect any database.

Expected behavior

The RPC function databases.configured.disconnect should only be available to Mathesar admins

Additional context

The solution is to simply change the basic auth decorator on the relevant function.
@mathemancer mathemancer added type: bug Something isn't working work: backend Related to Python, Django, and simple SQL ready Ready for implementation labels Nov 4, 2024
@mathemancer mathemancer added this to the v0.2.0 (beta release) milestone Nov 4, 2024
@mathemancer mathemancer added good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this labels Nov 4, 2024
@Anish9901 Anish9901 linked a pull request Nov 12, 2024 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation type: bug Something isn't working work: backend Related to Python, Django, and simple SQL
Projects
None yet
Milestone
v0.2.0 (beta release)
Development

Successfully merging a pull request may close this issue.

Allow only superusers to disconnect configured DBs mathesar-foundation/mathesar
1 participant
@mathemancer