Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

Simplify Shrine theming #104

Open
guidezpl opened this issue May 17, 2021 · 1 comment
Open

Simplify Shrine theming #104

guidezpl opened this issue May 17, 2021 · 1 comment

Comments

@guidezpl
Copy link
Member

guidezpl commented May 17, 2021

The dev docs have a bunch of slightly different Shrine theme implementations, which are also suboptimal due to changes in the theming system.

Write a single canonical Shrine theme and use it everywhere. (if Dartpad supported pub packages dart-lang/dart-pad#901, defining it once through one would ideal)

This should be somewhat easier after theming code is removed from .md files (#103)

@guidezpl
Copy link
Member Author

material-components/material-components-flutter-codelabs#242 has the new Shrine theme implementation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant