Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently use ref callback for accessing component DOM element #179

Open
stomita opened this issue Feb 14, 2017 · 0 comments
Open

Consistently use ref callback for accessing component DOM element #179

stomita opened this issue Feb 14, 2017 · 0 comments

Comments

@stomita
Copy link
Collaborator

stomita commented Feb 14, 2017

Currently there are ways of accessing DOM element in the component.
For instance, the xxxRef callback approach is used in Input component to retrieve the <input> element, but DateInput uses undocumented instance property of this.input to access its inner <input> element.

To bring consistency, every component should only have reference callback for accessing inner DOM elements, not instance property.

This change will make corruption to existing app which refers DOM element instance property, the deprecation should be done in major update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant