Skip to content

Commit d25187e

Browse files
tianyizheng02github-actionscclausspre-commit-ci[bot]
authored
Remove type cast in combinations algorithm (TheAlgorithms#7607)
* Remove commented-out print statements in algorithmic functions * Encapsulate non-algorithmic code in __main__ * Remove unused print_matrix function * Remove print statement in __init__ * Remove print statement from doctest * Encapsulate non-algorithmic code in __main__ * Modify algorithm to return instead of print * Encapsulate non-algorithmic code in __main__ * Refactor data_safety_checker to return instead of print * updating DIRECTORY.md * updating DIRECTORY.md * Apply suggestions from code review * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * updating DIRECTORY.md * Remove int cast and change float division to int division * Move new-line chars * updating DIRECTORY.md Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com> Co-authored-by: Christian Clauss <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
1 parent 103c9e0 commit d25187e

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

maths/combinations.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -35,24 +35,24 @@ def combinations(n: int, k: int) -> int:
3535
# to calculate a factorial of a negative number, which is not possible
3636
if n < k or k < 0:
3737
raise ValueError("Please enter positive integers for n and k where n >= k")
38-
return int(factorial(n) / ((factorial(k)) * (factorial(n - k))))
38+
return factorial(n) // (factorial(k) * factorial(n - k))
3939

4040

4141
if __name__ == "__main__":
4242

4343
print(
44-
"\nThe number of five-card hands possible from a standard",
45-
f"fifty-two card deck is: {combinations(52, 5)}",
44+
"The number of five-card hands possible from a standard",
45+
f"fifty-two card deck is: {combinations(52, 5)}\n",
4646
)
4747

4848
print(
49-
"\nIf a class of 40 students must be arranged into groups of",
49+
"If a class of 40 students must be arranged into groups of",
5050
f"4 for group projects, there are {combinations(40, 4)} ways",
5151
"to arrange them.\n",
5252
)
5353

5454
print(
5555
"If 10 teams are competing in a Formula One race, there",
5656
f"are {combinations(10, 3)} ways that first, second and",
57-
"third place can be awarded.\n",
57+
"third place can be awarded.",
5858
)

0 commit comments

Comments
 (0)