fourth drop of clojure-portlet (refactor to more idiomatic clojure)

Author: martinlau

src/main/clojure/au/com/permeance/clojure/clojure_portlet.clj

@@ -12,9 +12,9 @@
                    processClojureRender [javax.portlet.RenderRequest javax.portlet.RenderResponse] void]])
 
 (defn -processClojureAction [portlet request response]
-  (set-render-parameter response "message" "An action occurred"))
+  (set-render-parameters response {:message "An action occurred"}))
 
 (defn -processClojureRender [portlet request response]
-  (set-render-attribute request "message"
-    (or (get-request-paramater request "message") "Nothing happened"))
-  (dispatch portlet "/view.jsp" request response))
+  (let [param (first (:message (get-request-parameters request)))
+        message (or param "Nothing happened")]
+    (dispatch portlet "/view.jsp" {:message message} request response)))

src/main/clojure/au/com/permeance/clojure/portlet.clj

@@ -1,14 +1,26 @@
 (ns au.com.permeance.clojure.portlet)
 
-(defn set-render-parameter [response name value]
-  (. response setRenderParameter name value))
+(defn- do-with-map [f m]
+  (doseq [kv m]
+    (let [k (name (key kv))
+          v (val kv)]
+      (f k v))))
 
-(defn set-render-attribute [request name value]
-  (. request setAttribute name value))
+(defn- set-render-attributes [request attributes]
+  (do-with-map #(. request setAttribute %1 %2) attributes))
 
-(defn get-request-paramater [request name]
-  (. request getParameter name))
+(defn dispatch
+  ([portlet path request response]
+   (let [dispatcher (.. portlet (getPortletContext) (getRequestDispatcher path))]
+     (. dispatcher include request response)))
+  ([portlet path attributes request response]
+   (set-render-attributes request attributes)
+   (dispatch portlet path request response)))
+
+(defn get-request-parameters [request]
+  (let [parameters (. request getParameterMap)]
+    (into {} (for [[k v] parameters] [(keyword k) v]))))
+
+(defn set-render-parameters [response parameters]
+  (do-with-map #(. response setRenderParameter %1 %2) parameters))
 
-(defn dispatch [portlet path request response]
-  (let [dispatcher (.. portlet (getPortletContext) (getRequestDispatcher path))]
-   (. dispatcher include request response)))