Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-grade to jsass 5.11.0 #1026

Conversation

reckart
Copy link
Contributor

@reckart reckart commented Jan 2, 2024

No description provided.

@martin-g martin-g merged commit 780c35a into martin-g:wicket-9.x-bootstrap-5.x Jan 3, 2024
2 checks passed
martin-g pushed a commit that referenced this pull request Jan 3, 2024
(cherry picked from commit 780c35a)
@martin-g
Copy link
Owner

martin-g commented Jan 3, 2024

Thank you, @reckart !

@reckart
Copy link
Contributor Author

reckart commented Jan 3, 2024

@martin-g would you cherry-pick it into the other relevant branches as well?

@martin-g
Copy link
Owner

martin-g commented Jan 3, 2024

which ones ?

@reckart
Copy link
Contributor Author

reckart commented Jan 3, 2024

TBH, I am a bit confused about the branches a bit.

The PR I made was against the 9.x-bs-5 branch. But there is also the wicket-9.x default branch, the 9.x-bs-4 branch and of course the 10.x-bs-5 branch.

How about making the 9.x-bs-5 the default branch?

I guess the change should be cherry-picked or up-merged at least into the 10.x-bs-5 branch.

@reckart
Copy link
Contributor Author

reckart commented Jan 3, 2024

Oh and there is the "master" branch as well...

@martin-g
Copy link
Owner

martin-g commented Jan 3, 2024

I do not own the repository and I cannot make such kind of changes.
I just merge people's PRs and cut releases :-)

@reckart
Copy link
Contributor Author

reckart commented Jan 3, 2024

@martin-g maybe you need a permission upgrade from the owner ;)

@martin-g
Copy link
Owner

martin-g commented Jan 3, 2024

I haven't thought about this before :-) Or did I ?! Well, I still don't have permissions ...

@reckart
Copy link
Contributor Author

reckart commented Jan 3, 2024

@l0rdn1kk0n ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants