Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guava as dependency #1025

Conversation

keesvandieren
Copy link
Contributor

Guava is missing but needed. It got unnoticed because it was delivered as transitive dependency of optional dependency in bootstrap-extensions

See #1024

@martin-g
Copy link
Owner

No!
Guava should not be used at all! It brings only problems!

@martin-g martin-g closed this Dec 13, 2023
@keesvandieren
Copy link
Contributor Author

Thanks for fixing! de.agilecoders.wicket.extensions.markup.html.bootstrap.form.typeaheadV10.TypeaheadConfig also has reference to com.google.common.collect.ObjectArrays. Can you replace that too?

@martin-g
Copy link
Owner

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants