From 0fbc1ab991947a5b77a6defb403fb4f93b9e9cd1 Mon Sep 17 00:00:00 2001
From: PartialVolume <22084881+PartialVolume@users.noreply.github.com>
Date: Thu, 12 Sep 2024 21:28:37 +0100
Subject: [PATCH] Fixes a issue where SAS drives always respond with hidden
 sectors = ???, i.e warning. This patch fixes the problem so that a SAS drive
 responds with hidden sectors = not applicable. A SATA drive connected to a
 SAS interface should still respond with yes or no subject to the interface
 passing HPA and DCO-identify commands.

---
 src/hpa_dco.c | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/src/hpa_dco.c b/src/hpa_dco.c
index bbd3d1cd..547ab64a 100644
--- a/src/hpa_dco.c
+++ b/src/hpa_dco.c
@@ -570,13 +570,22 @@ int hpa_dco_status( nwipe_context_t* ptr )
          * through */
         if( c->HPA_reported_set == 0 && c->HPA_reported_real == 0 && c->DCO_reported_real_max_sectors <= 1 )
         {
-            c->HPA_status = HPA_UNKNOWN;
-            if( c->device_bus == NWIPE_DEVICE_USB )
+            if( c->device_bus == NWIPE_DEVICE_SAS )
             {
-                nwipe_log( NWIPE_LOG_WARNING,
-                           "HIDDEN SECTORS INDETERMINATE! on %s, Some USB adapters & memory sticks don't support "
-                           "ATA pass through",
-                           c->device_name );
+                /* SAS SCSI doesn't appear to support HPA/DCO commands */
+                c->HPA_status = HPA_NOT_APPLICABLE;
+                nwipe_log( NWIPE_LOG_INFO, "No hidden sectors on %s", c->device_name );
+            }
+            else
+            {
+                c->HPA_status = HPA_UNKNOWN;
+                if( c->device_bus == NWIPE_DEVICE_USB )
+                {
+                    nwipe_log( NWIPE_LOG_WARNING,
+                               "HIDDEN SECTORS INDETERMINATE! on %s, Some USB adapters & memory sticks don't support "
+                               "ATA pass through",
+                               c->device_name );
+                }
             }
         }
         else