Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell orientation preservation under dim=2 and spacedim=3 #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jihuan-tian
Copy link

  1. Modified convert_triangles and change_vertices_order for preserving the orientations of quadrangular cells, under the case dim=2 and spacedim=3. The consistency of orientations between the parent triangle and children quadrangles is evaluated by checking cell normal vectors instead of 2D cell measure, which cannot be used in this case.

  2. Add .clang-format.

…g the orientations of quadrangular cells, under the case dim=2 and spacedim=3.

2. Add .clang-format.
@martemyev
Copy link
Owner

Hi Jihuan,

Thanks for the PR! While I appreciate the clang-format changes and I fully support enforcing one code style for future projects, I do not think that it is warranted for this project. Hence I would prefer not to change that.

Regarding the preservation of the orientation of quadrangular cells - could you please create an issue for that, so that it could be more clear what the problem is? Then a PR containing the fix (with tests) for that particular issue would be more than welcome.

Thanks,
Mikhail

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants