Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Nov 25, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 25, 2025 20:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds TypeScript support and runtime validation tests for MarkLogic database client convenience methods, specifically for server-side code evaluation functions (eval, xqueryEval, and invoke).

Key Changes:

  • Added comprehensive runtime validation tests for DatabaseClient convenience methods
  • Implemented test coverage for JavaScript and XQuery evaluation capabilities
  • Added a simple XQuery module for testing the invoke method

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
typescript-test-project/test.ts Added demonstration code testing eval, xqueryEval, and invoke methods
test-typescript/dbclient-convenience-runtime.test.ts New comprehensive test suite validating all DatabaseClient convenience methods with runtime assertions
test-app/src/main/ml-modules/root/hello.xqy Simple XQuery module added to support invoke method testing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

Copyright Validation Results
Total: 4 | Passed: 3 | Failed: 0 | Skipped: 1 | at: 2025-11-25 20:47:07 UTC | commit: 07d1135

⏭️ Skipped (Excluded) Files

  • test-app/src/main/ml-modules/root/hello.xqy

✅ Valid Files

  • marklogic.d.ts
  • test-typescript/dbclient-convenience-runtime.test.ts
  • typescript-test-project/test.ts

✅ All files have valid copyright headers!

@rjrudin rjrudin merged commit 9ecf413 into develop Nov 25, 2025
6 checks passed
@rjrudin rjrudin deleted the feature/25617-ts-dbclient branch November 25, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants