MLE-23004 - Cleaning up compiler warnings

Author: BillFarber

marklogic-client-api/src/main/java/com/marklogic/client/datamovement/TypedRow.java

@@ -20,7 +20,11 @@ public String getUri() {
   }
 
   public long getRowNum() {
-    return new Long(rowNum).longValue();
+    try {
+      return Long.valueOf(rowNum).longValue();
+    } catch (NumberFormatException e) {
+      throw new IllegalArgumentException("Invalid rowNum value: " + rowNum, e);
+    }
   }
 
   public XsAnyAtomicTypeVal put(String name, XsAnyAtomicTypeVal val) {

marklogic-client-api/src/main/java/com/marklogic/client/impl/BasicPage.java

@@ -69,16 +69,17 @@ public BasicPage<T> setTotalSize(long totalSize) {
   }
 
   public BasicPage<T> setSize(long size) {
-    this.size = new Long(size);
+    this.size = Long.valueOf(size);
     return this;
   }
 
   @Override
   public long size() {
-    if ( size != null ) return size.longValue();
-    if ( getPageSize() == 0 ) {
+    if (size != null)
+      return size.longValue();
+    if (getPageSize() == 0) {
       return 0;
-    } else if ( hasNextPage() ) {
+    } else if (hasNextPage()) {
       return getPageSize();
     } else if ((getTotalSize() % getPageSize()) == 0) {
       return getPageSize();
@@ -113,20 +114,23 @@ public long getPageNumber() {
   }
 
   private long ceilingDivision(long dividend, long divisor) {
-    if (divisor == 0) return 0;
+    if (divisor == 0)
+      return 0;
     long quotient = dividend / divisor;
     return (dividend % divisor == 0) ? quotient : quotient + 1;
   }
 
   @Override
   public boolean isFirstPage() {
-    if ( getPageSize() == 0 ) return true;
+    if (getPageSize() == 0)
+      return true;
     return getPageNumber() == 1;
   }
 
   @Override
   public boolean isLastPage() {
-    if ( getPageSize() == 0 ) return true;
+    if (getPageSize() == 0)
+      return true;
     return getPageNumber() == getTotalPages();
   }
 }