Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XF 4.x support #1

Open
jdluzen opened this issue Feb 1, 2020 · 4 comments
Open

XF 4.x support #1

jdluzen opened this issue Feb 1, 2020 · 4 comments

Comments

@jdluzen
Copy link

jdluzen commented Feb 1, 2020

Hello and thanks for this great project!

After directly using the nuget package in my project, neither the BeforeAfter.BeforeView nor BeforeAfter.AfterView showed up.

I ran your sample app which ran successfully on XF 3.3. I then updated the packages to XF 4.4, and the Before/AfterView stopped showing up.

image

@jdluzen
Copy link
Author

jdluzen commented Feb 1, 2020

On XF 3.3, OnSizeAllocated is called with what looks like proper values, ~314 in my case.
On XF 4.4 OnSizeAllocated is called with 1, 1.

@jdluzen
Copy link
Author

jdluzen commented Feb 9, 2020

I've spent a good amount of time debugging this, and it seems to be isolated to the ContentPresenter. The view isn't being rendered at all. I'm unsure what has changed since XF 3.3.

@gsgou
Copy link

gsgou commented Nov 6, 2022

@jdluzen, @mariusmuntean did you by chance find any workaround?
Just noticed the issue persists also on 5.0.0.2515.

@gsgou
Copy link

gsgou commented Nov 6, 2022

@jdluzen, @mariusmuntean send a PR with a fix.

The ContentPresenter should be placed in a control template to mark where content to be displayed by the templated custom control will appear. I replaced it with a ContentView.

https://learn.microsoft.com/en-us/xamarin/xamarin-forms/app-fundamentals/templates/control-template#substitute-content-into-a-contentpresenter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants