Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script does not replace buildItemView #37

Open
valleywood opened this issue Mar 4, 2015 · 2 comments
Open

Script does not replace buildItemView #37

valleywood opened this issue Mar 4, 2015 · 2 comments

Comments

@valleywood
Copy link

buildItemView has been renamed to buildChildView but the script does not seem to handle this.

@samccone
Copy link
Member

samccone commented Mar 4, 2015

Interesting @valleywood it looks like according to the source that it should:
https://github.com/marionettejs/Marionette.Upgrade/blob/master/upgrade.py#L147

Perhaps maybe tweak the matcher and see if you can get it to work?

@samccone
Copy link
Member

samccone commented Mar 4, 2015

(very open to PRs) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants