From fb60ecac9e1f75d11653e8e6cd421e23c3bb2450 Mon Sep 17 00:00:00 2001
From: marianfoo <13335743+marianfoo@users.noreply.github.com>
Date: Fri, 7 Aug 2026 10:43:54 +0200
Subject: [PATCH 1/5] test: define ZTOAD enhancement contract
---
.../base-ddic-001-enhancement-category.md | 58 +++++++++++++++++++
...8-07-base-ddic-001-enhancement-category.md | 43 ++++++++++++++
scripts/repository-contract.mjs | 18 +++++-
3 files changed, 118 insertions(+), 1 deletion(-)
create mode 100644 docs/plans/base-ddic-001-enhancement-category.md
create mode 100644 docs/research/2026-08-07-base-ddic-001-enhancement-category.md
diff --git a/docs/plans/base-ddic-001-enhancement-category.md b/docs/plans/base-ddic-001-enhancement-category.md
new file mode 100644
index 0000000..003ad7a
--- /dev/null
+++ b/docs/plans/base-ddic-001-enhancement-category.md
@@ -0,0 +1,58 @@
+# BASE-DDIC-001 enhancement-category plan
+
+_Created: 2026-08-07 · finding: `BASE-DDIC-001` · target branch: `codex/fix-base-ddic-001`_
+
+## Objective
+
+Remove the offline-install warning and persistent table drift by declaring table `ZTOAD` as `#NOT_EXTENSIBLE` and round-tripping the structural metadata through native abapGit.
+
+## Red evidence and test
+
+- `src/ztoad.tabl.xml` has no `DD02V-EXCLASS` element.
+- Both live systems report `#NOT_CLASSIFIED`; the NPL offline pull warned that the enhancement category was missing.
+- Add a repository contract requiring the native-abapGit value `1`. Replay it against the current XML and record the intended red failure before changing the table.
+- Red replay: `npm run test:repository` exits 1 at the focused `DD02V-EXCLASS 1` assertion; the existing launcher and forbidden-kernel-call assertions are reached first and remain green.
+
+## Implementation
+
+1. Commit and push the red contract plus this reviewed plan so the coordinated native-abapGit branch exists remotely.
+2. On A4H, refresh/check the shared repository while it is still on `refs/heads/master`, record all drift, then switch using the full feature ref and verify the selected branch with a fresh read.
+3. Change only the active table annotation to `#NOT_EXTENSIBLE` through ARC-1, explicitly activate `TABL ZTOAD`, and confirm its fields and technical properties are unchanged.
+4. Refresh native abapGit, stage only `TABL ZTOAD`, review the exact object/file diff, push it to the feature branch, and fetch the resulting serializer commit locally. Never select the package or use **Add All**.
+5. Restore the shared A4H repository with the full `refs/heads/master` ref, verify the branch and clean state, and explicitly confirm the intended active master object state after validation.
+6. Import/validate the exact serialized table on NPL through the existing offline repository boundary; all validation remains UI-free through ARC-1 after the structural import.
+
+## Required gates
+
+### Local
+
+- red repository-contract replay before SAP change;
+- `npm ci`, `npm test`, `git diff --check`;
+- serializer diff limited to the expected enhancement-category field;
+- complete diff, XML, compatibility, security, and Clean ABAP/Clean Core review.
+
+### NPL / SAP_BASIS 750 first
+
+- real `TABL ZTOAD` activation with no enhancement-category warning;
+- active source shows `#NOT_EXTENSIBLE` and all seven fields are unchanged;
+- zero inactive ZTOAD parts;
+- `PROG ZTOAD` active syntax, all 67 ABAP Unit tests, and complete `DEFAULT` ATC compared with the 88-finding baseline.
+
+### A4H / SAP_BASIS 758
+
+- exact serialized table activation and active category/field verification;
+- zero inactive ZTOAD parts;
+- active report syntax, all 67 ABAP Unit tests, and recorded ATC variants compared with baseline;
+- browser/ST22 is not applicable because runtime source, screens, transaction, and table columns are unchanged.
+
+## Rollback
+
+Restore `TABL ZTOAD` from the reviewed `master` serialization through native abapGit and explicitly activate it. No column conversion or persistent-data migration is involved. Restore the shared repository to `refs/heads/master` even if another gate fails.
+
+## Plan review
+
+- `#NOT_EXTENSIBLE` is the narrow SAP-supported category and does not promise unsupported appends.
+- The repository contract checks the exact abapGit representation.
+- Structural XML comes only from a native-abapGit round trip.
+- The coordinated branch procedure prevents a system-only or master-only structural mutation.
+- Live gates cover both supported releases while respecting NPL's no-UI boundary.
diff --git a/docs/research/2026-08-07-base-ddic-001-enhancement-category.md b/docs/research/2026-08-07-base-ddic-001-enhancement-category.md
new file mode 100644
index 0000000..3577a03
--- /dev/null
+++ b/docs/research/2026-08-07-base-ddic-001-enhancement-category.md
@@ -0,0 +1,43 @@
+# BASE-DDIC-001: explicit table enhancement category
+
+_Research date: 2026-08-07 · targets: SAP_BASIS 750 and SAP_BASIS 758_
+
+## Outcome
+
+Table `ZTOAD` should declare `#NOT_EXTENSIBLE`. The table is an internal persistence detail of the report, exposes no append contract, and contains a deep `STRING` component. Allowing arbitrary extensions would broaden a compatibility surface the project does not test or support.
+
+The current serializer omits `DD02V-EXCLASS`. Both SAP targets consequently expose the active table as `#NOT_CLASSIFIED`; NPL also warned during the offline pull and produced a persistent local/remote table diff.
+
+## SAP guidance
+
+SAP documents five enhancement categories. It explicitly states that `#NOT_CLASSIFIED` exists only for already-existing unclassified objects and should not be used when an object is created or changed. The current ABAP keyword documentation describes `#NOT_EXTENSIBLE` as “cannot be enhanced”. The extensible categories allow respectively character-like flat, character/numeric flat, or arbitrary/deep append components.
+
+Because `ZTOAD` is being changed and has no public extension point, `#NOT_EXTENSIBLE` is the narrow, explicit category. `#EXTENSIBLE_CHARACTER` and `#EXTENSIBLE_CHARACTER_NUMERIC` are also incompatible with the existing deep `QUERY` field; `#EXTENSIBLE_ANY` would deliberately promise an extension contract that does not exist.
+
+References:
+
+- [SAP Help: Structure Annotations, ABAP Platform 2023 FPS02](https://help.sap.com/docs/ABAP_PLATFORM_NEW/c238d694b825421f940829321ffa326a/afd07524f9ab41e0995ddd9cfdf148c2.html?locale=en-US&state=PRODUCTION&version=202310.002#loio4bfbcb53a8784972a3be0efabc1e81f5)
+- [ABAP Keyword Documentation: DDIC structure properties](https://help.sap.com/doc/abapdocu_latest_index_htm/latest/en-US/ABENDDICDDL_DEFINE_STRUCT_PROPS.html)
+
+## abapGit representation
+
+The official abapGit TABL DDL serializer maps these values:
+
+| DD02V `EXCLASS` | DDL category |
+|---:|---|
+| `0` | `#NOT_CLASSIFIED` |
+| `1` | `#NOT_EXTENSIBLE` |
+| `2` | `#EXTENSIBLE_CHARACTER` |
+| `3` | `#EXTENSIBLE_CHARACTER_NUMERIC` |
+| `4` | `#EXTENSIBLE_ANY` |
+
+Therefore the repository contract can require `1`. The value must be produced by changing the table in SAP and exporting `TABL ZTOAD` with native abapGit; it must not be hand-authored into serializer XML.
+
+Reference: [abapGit TABL DDL serializer](https://github.com/abapGit/abapGit/blob/88524f72ec9177efd8445ff209c7a8218b216f7a/src/objects/tabl/zcl_abapgit_object_tabl_ddl.clas.abap#L720-L735)
+
+## Compatibility and risk
+
+- The category is metadata supported by both 7.50 and 758.
+- No column, key, type, delivery class, technical setting, or stored row changes.
+- Existing code has no append dependency; live structure discovery found no append on NPL. A4H where-used structure discovery is unavailable through its older ARC-1 adapter, so the native-abapGit diff and activation preaudit must remain authoritative there.
+- Rollback is a reviewed native-abapGit restoration of the previous table serialization. Returning to unclassified metadata is not recommended, but it does not require a database conversion.
diff --git a/scripts/repository-contract.mjs b/scripts/repository-contract.mjs
index 59d1ffc..7b973fa 100644
--- a/scripts/repository-contract.mjs
+++ b/scripts/repository-contract.mjs
@@ -2,9 +2,11 @@ import { readFile } from "node:fs/promises";
import { strict as assert } from "node:assert";
const transactionPath = new URL("../src/ztoad.tran.xml", import.meta.url);
+const tablePath = new URL("../src/ztoad.tabl.xml", import.meta.url);
const reportPath = new URL("../src/ztoad.prog.abap", import.meta.url);
let transactionXml;
+let tableXml;
let reportSource;
try {
@@ -16,6 +18,15 @@ try {
throw error;
}
+try {
+ tableXml = await readFile(tablePath, "utf8");
+} catch (error) {
+ if (error?.code === "ENOENT") {
+ throw new Error("Missing native-abapGit table object: src/ztoad.tabl.xml");
+ }
+ throw error;
+}
+
reportSource = await readFile(reportPath, "utf8");
const expectedFragments = [
@@ -37,9 +48,14 @@ for (const fragment of expectedFragments) {
);
}
+assert.ok(
+ tableXml.includes("1"),
+ "src/ztoad.tabl.xml must serialize TABL ZTOAD as #NOT_EXTENSIBLE (DD02V-EXCLASS 1)",
+);
+
assert.ok(
!reportSource.includes("C_DB_EXECUTE"),
"Unsupported native SQL kernel call C_DB_EXECUTE must not exist in src/ztoad.prog.abap",
);
-console.log("Repository contract passed: launcher metadata and forbidden-kernel-call checks are green.");
+console.log("Repository contract passed: launcher, table, and forbidden-kernel-call checks are green.");
From 4206a1a698c2f743119b1b72453f194a5cdfa036 Mon Sep 17 00:00:00 2001
From: marianfoo <13335743+marianfoo@users.noreply.github.com>
Date: Fri, 7 Aug 2026 08:50:32 +0000
Subject: [PATCH 2/5] fix: classify ZTOAD table as not extensible
---
src/ztoad.tabl.xml | 19 ++-----------------
1 file changed, 2 insertions(+), 17 deletions(-)
diff --git a/src/ztoad.tabl.xml b/src/ztoad.tabl.xml
index 755cfac..64a9acc 100644
--- a/src/ztoad.tabl.xml
+++ b/src/ztoad.tabl.xml
@@ -7,7 +7,9 @@
E
TRANSP
ZTOAD
+ E
A
+ 1
ZTOAD
@@ -18,9 +20,7 @@
- ZTOAD
QUERYID
- 0001
X
GUID_32
0
@@ -28,26 +28,19 @@
E
- ZTOAD
OWNER
- 0002
SYUNAME
0
E
- ZTOAD
AEDAT
- 0003
TIMESTAMP
0
E
- ZTOAD
VISIBILITY
- E
- 0004
0
C
000002
@@ -56,18 +49,13 @@
CHAR
- ZTOAD
VISIBILITY_GROUP
- 0005
XUCLASS
0
E
- ZTOAD
TEXT
- E
- 0006
0
C
000060
@@ -76,10 +64,7 @@
CHAR
- ZTOAD
QUERY
- E
- 0007
0
g
000008
From 3d6008f741c0f1a0d44254258c538f1c363dacc0 Mon Sep 17 00:00:00 2001
From: marianfoo <13335743+marianfoo@users.noreply.github.com>
Date: Fri, 7 Aug 2026 10:55:56 +0200
Subject: [PATCH 3/5] docs: record BASE-DDIC-001 candidate evidence
---
docs/baseline-findings.md | 4 ++--
docs/development.md | 2 ++
docs/plans/base-ddic-001-enhancement-category.md | 9 +++++++++
.../2026-08-07-arc1-abapgit-integration-audit.md | 5 ++++-
.../2026-08-07-base-ddic-001-enhancement-category.md | 9 +++++++++
5 files changed, 26 insertions(+), 3 deletions(-)
diff --git a/docs/baseline-findings.md b/docs/baseline-findings.md
index d462134..3597298 100644
--- a/docs/baseline-findings.md
+++ b/docs/baseline-findings.md
@@ -48,10 +48,10 @@ Priority meanings: **P0** blocks the requested test workflow or is an immediate
| BASE-CLEAN-001 | P2 | Clean-core status is provisionally Level D/unknown because of `CL_GUI_ABAPEDIT`, DDIC internals such as `DD03L`, system/kernel calls, and other unreleased references. Classic controls such as `CL_GUI_ALV_GRID` are Level B on-premise APIs. | Replace/encapsulate unsupported and unknown references, then re-run released-API ATC and document accepted Level B dependencies. | Open |
| BASE-TOOL-001 | P2 | ARC-1 0.9.19 can list/check this native-abapGit repository but its clone call sends an XML shape rejected by A4H 758 (`repository` namespace mismatch). Native abapGit UI was required to link/pull. | Minimal ARC-1 integration reproduction against A4H 758; fix ARC-1 separately, keep UI fallback documented. | Open |
| BASE-ENV-001 | P2 | NPL and `arc-1-750` are configured. SAP_BASIS 750 cannot create the transparent table through ADT, so the maintainer provisioned the complete repository once with native abapGit 1.134.0 from an offline ZIP in local package `$ZTOAD2`. | Require exact source activation/state, SAP syntax, all Unit tests, complete `DEFAULT` ATC, and zero inactive ZTOAD parts through ARC-1. NPL UI smoke remains out of scope. | Fixed: exact candidate is 67/67 with zero syntax errors, unchanged 88-finding ATC baseline, and no inactive ZTOAD part |
-| BASE-DDIC-001 | P2 | Offline NPL installation warns that the table enhancement category is missing and normalizes `ZTOAD` to `#NOT_CLASSIFIED`, leaving a persistent table serialization difference. | Choose the explicit compatible category from SAP guidance, change the table in SAP, export only `TABL ZTOAD` through native abapGit, and require activation plus clean round trips on 750 and 758. | Open; separate structural PR |
+| BASE-DDIC-001 | P2 | Offline NPL installation warns that the table enhancement category is missing and normalizes `ZTOAD` to `#NOT_CLASSIFIED`, leaving a persistent table serialization difference. | Require `1` (`#NOT_EXTENSIBLE`), native-abapGit export of only `TABL ZTOAD`, and activation plus reviewed round trips on 750 and 758. | Candidate `4206a1a`: red/green contract and A4H structural/Unit/syntax gates pass; exact NPL offline import pending |
| BASE-TOOL-002 | P2 | ARC-1 1.0.2 detects NPL release 750, but its lint inventory reports `v702`/unknown; absent `PROG ZTOAD` is misclassified as a class-local include, and nonexistent `DEVC ZTOAD` returns unrelated objects. | Add focused ARC-1 integration reproductions on NPL and correct release propagation, not-found hints, and package resolution in the ARC-1 project. | Open |
| BASE-TOOL-003 | P2 | The local A4H ARC-1 pre-write linter also selected ABAP v702 and rejected valid 7.50+ syntax. The live SAP preflight accepted the exact source, and A4H activated it with zero syntax errors. | Propagate probed/configured SAP release into pre-write lint. Until fixed, bypass only `lintBeforeWrite` after repository abaplint is green; retain live preflight, explicit activation, syntax, Unit, and object-state checks. | Open |
-| BASE-TOOL-004 | P2 | ARC-1 1.0.2 native-abapGit/CLI testing found cold-process feature detection, `stage` write-scope classification, unverified short-ref branch switching, weak remote-auth diagnostics, and no surgical edit support for local classes inside `PROG`. | Implement on-demand feature probing, normalize and verify refs, classify actual mutations, improve credential/postcondition JSON, and support report-local methods or narrow the documented contract. | Open; detailed audit in `docs/research/2026-08-07-arc1-abapgit-integration-audit.md` |
+| BASE-TOOL-004 | P2 | ARC-1 native-abapGit/CLI testing found cold-process feature detection, stage/push/pull XML contract mismatches, unverified short refs, weak remote-auth diagnostics, mutating TABL `dryRun`, and no surgical local-class edit inside `PROG`. | Add on-demand probing, backend-versioned XML fixtures, normalized verified refs, non-mutating dry runs, credential/postcondition JSON, and supported report-local method editing. | Open; detailed audit in `docs/research/2026-08-07-arc1-abapgit-integration-audit.md` |
| BASE-REL-001 | P2 | Source declares 4.0.4 but the latest Git tag is 4.0.3. Release Please uses 4.0.4 as its manifest baseline, but its first compare link expects that tag. | After both live gates pass at an exact commit, decide whether to create the one-time immutable 4.0.4 tag/release. | Decision |
| BASE-CTS-001 | P3 | Setup left empty local request `A4HK906377`; active work is in `A4HK906379`. | Manual owner decision whether to retain or delete the empty request. No automated deletion. | Decision |
diff --git a/docs/development.md b/docs/development.md
index ceb70d6..e3754ef 100644
--- a/docs/development.md
+++ b/docs/development.md
@@ -67,6 +67,8 @@ Do not manually install only the report source. That omits the dynpros, table, a
For an offline NPL refresh, create an offline repository bound to the dedicated local package, import a ZIP generated from the exact Git commit, review and pull only `PROG ZTOAD`, `TABL ZTOAD`, `TRAN ZTOAD`, and `SUSO ZTOAD_AUTH`, then activate. Do not export the system-local root package as `package.devc.xml`, and do not accept release-normalized table metadata without a deliberate structural review. After this one-time structural provisioning, deploy source-only candidates directly through ARC-1 and keep all NPL validation UI-free.
+Current ARC-1 TABL `dryRun` requests can still create an inactive draft. After any DDIC dry-run or preflight, compare active/inactive object state immediately; never infer non-mutation from the option name or success text. The A4H abapGit ADT backend also uses version-specific staging/pull XML namespaces, so an empty ARC-1 stage result is not proof of a clean repository—verify the raw bridge result or native client before pushing.
+
## 4. Local-first TDD flow with a stable `master`
`master` remains the only long-lived integration/release line and the normal branch of each shared native-abapGit link. Development uses a short-lived pull-request branch so CI and review can evaluate the candidate without placing an unreviewed state on `master`.
diff --git a/docs/plans/base-ddic-001-enhancement-category.md b/docs/plans/base-ddic-001-enhancement-category.md
index 003ad7a..07ed113 100644
--- a/docs/plans/base-ddic-001-enhancement-category.md
+++ b/docs/plans/base-ddic-001-enhancement-category.md
@@ -56,3 +56,12 @@ Restore `TABL ZTOAD` from the reviewed `master` serialization through native aba
- Structural XML comes only from a native-abapGit round trip.
- The coordinated branch procedure prevents a system-only or master-only structural mutation.
- Live gates cover both supported releases while respecting NPL's no-UI boundary.
+
+## Validation progress
+
+- Red contract commit `fb60eca` failed at the exact missing `EXCLASS 1` assertion.
+- Native-abapGit candidate commit `4206a1a`, table XML SHA-256 `0a7b98b6c073e5062c56bfd314dc297ecd88dc0ea685bee643caabc9a76a1f40`.
+- Local `npm ci`, `npm test`, and `git diff --check` are green.
+- A4H candidate activation/state, 67/67 Unit, syntax, inactive inventory, and recorded ATC gates are green; browser/ST22 remains not applicable.
+- A4H is restored to full `refs/heads/master`; current master report and pre-change table are active with no inactive divergence. The known table drift remains visible until this PR merges.
+- NPL is the remaining structural gate. Import `/tmp/ztoad-base-ddic-001.zip` (SHA-256 `a5c5745c55304e34f334ddb6b1e4ec7c4c3fbde9cf6ce46d01264f963059a4c5`) into the existing offline repository and select only `TABL ZTOAD`. After that one manual boundary, all activation/state/syntax/Unit/ATC evidence is collected through ARC-1.
diff --git a/docs/research/2026-08-07-arc1-abapgit-integration-audit.md b/docs/research/2026-08-07-arc1-abapgit-integration-audit.md
index 4172170..7d55240 100644
--- a/docs/research/2026-08-07-arc1-abapgit-integration-audit.md
+++ b/docs/research/2026-08-07-arc1-abapgit-integration-audit.md
@@ -4,7 +4,7 @@ _Observed 2026-08-06 to 2026-08-07 with ARC-1 1.0.2, A4H SAP_BASIS 758 SP02, nat
## What works
-- A4H has the native abapGit ADT bridge installed and usable. Repository discovery, details, status/check, full-ref branch switching, selective staging, and selective push all worked through the bridge.
+- A4H has the native abapGit ADT bridge installed and usable. Repository discovery, details, status/check, full-ref branch switching, selective staging, selective push, and pull all work at the bridge protocol level. Several ARC-1 request/parser shapes remain incompatible with this installed backend and required direct calls using the backend's published XML contract.
- Selective staging of `PROG ZTOAD` included only the five intended program serializer files and excluded unrelated `TABL`/`DEVC` drift.
- Native abapGit remained the authoritative complete-object round trip, while ARC-1 was effective for source reads/writes, activation, syntax, Unit, ATC, object state, and inactive-child diagnostics.
- The system is not missing a bridge component. The earlier clone namespace error belongs to the older ARC-1 request shape and should be retested with the current client before retaining it as an active system defect.
@@ -21,6 +21,8 @@ _Observed 2026-08-06 to 2026-08-07 with ARC-1 1.0.2, A4H SAP_BASIS 758 SP02, nat
8. **Large-source ergonomics should be first class.** Complete report writes require callers to build a temporary JSON payload to avoid stdin `EAGAIN`. Add a `sourceFile`/`--source-file` option that reads locally inside the CLI, reports the source hash, and never logs full source or credentials.
9. **Evidence-friendly output is incomplete.** Return staged object/file inventories, selected full ref, before/after commit IDs, and the exact remote result in stable JSON. This would make selective native-abapGit procedures auditable without scraping log previews.
10. **Published MCP schemas can lag the installed CLI.** The connected SAPGit MCP contract exposed only read actions while the local ARC-1 1.0.2 CLI supported `stage`, `push`, and `switch_branch`; the same skew hid newer diagnostic actions. Publish the running server/client version in discovery, keep action enums generated from one source, and fail with an explicit upgrade/reload instruction instead of forcing callers to discover CLI-only capabilities experimentally.
+11. **The installed backend's XML namespaces are not modeled correctly.** Its stage response uses `http://www.sap.com/adt/abapgit/staging`, so ARC-1 returned an empty object list even though raw XML contained `PROG` and `TABL`. ARC-1's push builder emitted a different generic `` payload, and its pull builder used singular `/repository` instead of the backend-required plural `/repositories` namespace. Version or discover the bridge contract, parse the staging namespace, preserve its staged-object shape, and add integration fixtures for this backend version.
+12. **`SAPWrite(dryRun=true)` mutated TABL state.** The call returned “Successfully updated” and created an inactive `TABL ZTOAD` draft. A dry run must never acquire/save a draft; until fixed, callers must compare active/inactive state after every DDIC dry-run request and clean up or deliberately continue only after reviewing the exact draft.
## Safe workflow until those gaps are fixed
@@ -30,6 +32,7 @@ _Observed 2026-08-06 to 2026-08-07 with ARC-1 1.0.2, A4H SAP_BASIS 758 SP02, nat
4. Stage explicit object selections, review returned filenames, and never use **Add All** with unrelated drift.
5. Treat native abapGit as the complete serializer and ARC-1 source writes as source-only unless the exact child-object closure is independently proven.
6. After activation, require active/inactive main equality plus the global inactive-child inventory for `PROG/P`, `PROG/PCA`, `PROG/PS`, and `PROG/PX`.
+7. Treat `dryRun` as untrusted on current TABL writes and verify object state immediately. When the bridge wrapper returns an empty stage for known drift, inspect the raw staging document before taking any push action.
## System-side conclusion
diff --git a/docs/research/2026-08-07-base-ddic-001-enhancement-category.md b/docs/research/2026-08-07-base-ddic-001-enhancement-category.md
index 3577a03..8928c45 100644
--- a/docs/research/2026-08-07-base-ddic-001-enhancement-category.md
+++ b/docs/research/2026-08-07-base-ddic-001-enhancement-category.md
@@ -41,3 +41,12 @@ Reference: [abapGit TABL DDL serializer](https://github.com/abapGit/abapGit/blob
- No column, key, type, delivery class, technical setting, or stored row changes.
- Existing code has no append dependency; live structure discovery found no append on NPL. A4H where-used structure discovery is unavailable through its older ARC-1 adapter, so the native-abapGit diff and activation preaudit must remain authoritative there.
- Rollback is a reviewed native-abapGit restoration of the previous table serialization. Returning to unclassified metadata is not recommended, but it does not require a database conversion.
+
+## Native round-trip evidence
+
+- Red contract commit: `fb60eca`; `npm run test:repository` failed only because `1` was absent.
+- Native-abapGit candidate commit: `4206a1a`; table XML SHA-256 `0a7b98b6c073e5062c56bfd314dc297ecd88dc0ea685bee643caabc9a76a1f40`.
+- A4H active candidate: `#NOT_EXTENSIBLE`, all seven fields unchanged, equal active/inactive table source, zero inactive ZTOAD parts, report syntax 0 errors plus two pre-existing POSIX warnings, and 67/67 Unit. `S4HANA_READINESS_2023` again returned zero rows with its known prerequisite limitation; Cloud ATC remained the unchanged legacy baseline.
+- The current serializer also added `MASTERLANG E` and removed redundant per-field `TABNAME`, `POSITION`, and `DDLANGUAGE` values. Field order, names, types, key, table class, delivery class, and technical settings are unchanged. This canonicalization is reviewed as part of the dedicated structural change.
+- Native abapGit staged only `TABL ZTOAD`; the pre-merge report drift was explicitly left unselected. A4H was then switched and pulled back to full `refs/heads/master`, activating current master report source and the pre-change unclassified table with equal active/inactive state.
+- Exact NPL import archive: `/tmp/ztoad-base-ddic-001.zip`, SHA-256 `a5c5745c55304e34f334ddb6b1e4ec7c4c3fbde9cf6ce46d01264f963059a4c5`. Only `TABL ZTOAD` is to be selected in the offline pull dialog; source will be synchronized separately through ARC-1.
From de501bb4b78eeededddf4c08625b64d7c9661db4 Mon Sep 17 00:00:00 2001
From: marianfoo <13335743+marianfoo@users.noreply.github.com>
Date: Fri, 7 Aug 2026 11:04:56 +0200
Subject: [PATCH 4/5] docs: record NPL structural validation
---
docs/baseline-findings.md | 3 ++-
docs/development.md | 2 +-
docs/plans/base-ddic-001-enhancement-category.md | 4 +++-
docs/research/2026-08-07-arc1-abapgit-integration-audit.md | 2 ++
.../2026-08-07-base-ddic-001-enhancement-category.md | 4 +++-
system-info.md | 6 +++---
6 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/docs/baseline-findings.md b/docs/baseline-findings.md
index 3597298..14e1949 100644
--- a/docs/baseline-findings.md
+++ b/docs/baseline-findings.md
@@ -48,9 +48,10 @@ Priority meanings: **P0** blocks the requested test workflow or is an immediate
| BASE-CLEAN-001 | P2 | Clean-core status is provisionally Level D/unknown because of `CL_GUI_ABAPEDIT`, DDIC internals such as `DD03L`, system/kernel calls, and other unreleased references. Classic controls such as `CL_GUI_ALV_GRID` are Level B on-premise APIs. | Replace/encapsulate unsupported and unknown references, then re-run released-API ATC and document accepted Level B dependencies. | Open |
| BASE-TOOL-001 | P2 | ARC-1 0.9.19 can list/check this native-abapGit repository but its clone call sends an XML shape rejected by A4H 758 (`repository` namespace mismatch). Native abapGit UI was required to link/pull. | Minimal ARC-1 integration reproduction against A4H 758; fix ARC-1 separately, keep UI fallback documented. | Open |
| BASE-ENV-001 | P2 | NPL and `arc-1-750` are configured. SAP_BASIS 750 cannot create the transparent table through ADT, so the maintainer provisioned the complete repository once with native abapGit 1.134.0 from an offline ZIP in local package `$ZTOAD2`. | Require exact source activation/state, SAP syntax, all Unit tests, complete `DEFAULT` ATC, and zero inactive ZTOAD parts through ARC-1. NPL UI smoke remains out of scope. | Fixed: exact candidate is 67/67 with zero syntax errors, unchanged 88-finding ATC baseline, and no inactive ZTOAD part |
-| BASE-DDIC-001 | P2 | Offline NPL installation warns that the table enhancement category is missing and normalizes `ZTOAD` to `#NOT_CLASSIFIED`, leaving a persistent table serialization difference. | Require `1` (`#NOT_EXTENSIBLE`), native-abapGit export of only `TABL ZTOAD`, and activation plus reviewed round trips on 750 and 758. | Candidate `4206a1a`: red/green contract and A4H structural/Unit/syntax gates pass; exact NPL offline import pending |
+| BASE-DDIC-001 | P2 | Offline NPL installation warns that the table enhancement category is missing and normalizes `ZTOAD` to `#NOT_CLASSIFIED`, leaving a persistent table serialization difference. | Require `1` (`#NOT_EXTENSIBLE`), native-abapGit export of only `TABL ZTOAD`, and activation plus reviewed round trips on 750 and 758. | Fixed candidate `4206a1a`: native round trip and both live structural gates pass; NPL is `#NOT_EXTENSIBLE`, 67/67 Unit, zero syntax errors, unchanged complete 88-finding ATC baseline, and no inactive ZTOAD part |
| BASE-TOOL-002 | P2 | ARC-1 1.0.2 detects NPL release 750, but its lint inventory reports `v702`/unknown; absent `PROG ZTOAD` is misclassified as a class-local include, and nonexistent `DEVC ZTOAD` returns unrelated objects. | Add focused ARC-1 integration reproductions on NPL and correct release propagation, not-found hints, and package resolution in the ARC-1 project. | Open |
| BASE-TOOL-003 | P2 | The local A4H ARC-1 pre-write linter also selected ABAP v702 and rejected valid 7.50+ syntax. The live SAP preflight accepted the exact source, and A4H activated it with zero syntax errors. | Propagate probed/configured SAP release into pre-write lint. Until fixed, bypass only `lintBeforeWrite` after repository abaplint is green; retain live preflight, explicit activation, syntax, Unit, and object-state checks. | Open |
+| BASE-TOOL-005 | P2 | On NPL, ARC-1 1.0.2's direct active `TABL` object-state request returns 404 for the installed transparent table while automatic/inactive-version reads, object search, explicit activation, and native abapGit all resolve it correctly. | Reuse `SAPRead`'s table/structure endpoint discovery in `SAPDiagnose(object_state)` and add a SAP_BASIS 750 transparent-table integration test. | Open; compensated by explicit activation, automatic plus inactive-version reads, exact metadata comparison, and the global inactive inventory |
| BASE-TOOL-004 | P2 | ARC-1 native-abapGit/CLI testing found cold-process feature detection, stage/push/pull XML contract mismatches, unverified short refs, weak remote-auth diagnostics, mutating TABL `dryRun`, and no surgical local-class edit inside `PROG`. | Add on-demand probing, backend-versioned XML fixtures, normalized verified refs, non-mutating dry runs, credential/postcondition JSON, and supported report-local method editing. | Open; detailed audit in `docs/research/2026-08-07-arc1-abapgit-integration-audit.md` |
| BASE-REL-001 | P2 | Source declares 4.0.4 but the latest Git tag is 4.0.3. Release Please uses 4.0.4 as its manifest baseline, but its first compare link expects that tag. | After both live gates pass at an exact commit, decide whether to create the one-time immutable 4.0.4 tag/release. | Decision |
| BASE-CTS-001 | P3 | Setup left empty local request `A4HK906377`; active work is in `A4HK906379`. | Manual owner decision whether to retain or delete the empty request. No automated deletion. | Decision |
diff --git a/docs/development.md b/docs/development.md
index e3754ef..29ac040 100644
--- a/docs/development.md
+++ b/docs/development.md
@@ -65,7 +65,7 @@ On A4H, the Fiori-shell URL for the transaction is:
Do not manually install only the report source. That omits the dynpros, table, authorization object, and transaction and cannot reproduce a supported installation. The repository-managed launcher is report transaction `ZTOAD` for program `ZTOAD`; use `#Shell-startGUI?sap-ui2-tcode=ZTOAD` or standalone `~transaction=ZTOAD` for its A4H smoke test.
-For an offline NPL refresh, create an offline repository bound to the dedicated local package, import a ZIP generated from the exact Git commit, review and pull only `PROG ZTOAD`, `TABL ZTOAD`, `TRAN ZTOAD`, and `SUSO ZTOAD_AUTH`, then activate. Do not export the system-local root package as `package.devc.xml`, and do not accept release-normalized table metadata without a deliberate structural review. After this one-time structural provisioning, deploy source-only candidates directly through ARC-1 and keep all NPL validation UI-free.
+For an offline NPL refresh, create an offline repository bound to the dedicated local package, import a ZIP generated from the exact Git commit, review and pull only `PROG ZTOAD`, `TABL ZTOAD`, `TRAN ZTOAD`, and `SUSO ZTOAD_AUTH`, then activate. For a structural-only change, select only the intended structural object. Do not export the system-local root package as `package.devc.xml`; if the pull review consequently proposes deleting `DEVC $ZTOAD2`, leave that row unselected. If a broader repository selection is applied accidentally, stop before a second pull and compare every selected object with the exact archive before deciding whether it is safe to keep. Do not accept release-normalized table metadata without a deliberate structural review. After this one-time structural provisioning, deploy source-only candidates directly through ARC-1 and keep all NPL validation UI-free.
Current ARC-1 TABL `dryRun` requests can still create an inactive draft. After any DDIC dry-run or preflight, compare active/inactive object state immediately; never infer non-mutation from the option name or success text. The A4H abapGit ADT backend also uses version-specific staging/pull XML namespaces, so an empty ARC-1 stage result is not proof of a clean repository—verify the raw bridge result or native client before pushing.
diff --git a/docs/plans/base-ddic-001-enhancement-category.md b/docs/plans/base-ddic-001-enhancement-category.md
index 07ed113..c3f933b 100644
--- a/docs/plans/base-ddic-001-enhancement-category.md
+++ b/docs/plans/base-ddic-001-enhancement-category.md
@@ -64,4 +64,6 @@ Restore `TABL ZTOAD` from the reviewed `master` serialization through native aba
- Local `npm ci`, `npm test`, and `git diff --check` are green.
- A4H candidate activation/state, 67/67 Unit, syntax, inactive inventory, and recorded ATC gates are green; browser/ST22 remains not applicable.
- A4H is restored to full `refs/heads/master`; current master report and pre-change table are active with no inactive divergence. The known table drift remains visible until this PR merges.
-- NPL is the remaining structural gate. Import `/tmp/ztoad-base-ddic-001.zip` (SHA-256 `a5c5745c55304e34f334ddb6b1e4ec7c4c3fbde9cf6ce46d01264f963059a4c5`) into the existing offline repository and select only `TABL ZTOAD`. After that one manual boundary, all activation/state/syntax/Unit/ATC evidence is collected through ARC-1.
+- NPL imported `/tmp/ztoad-base-ddic-001.zip` (SHA-256 `a5c5745c55304e34f334ddb6b1e4ec7c4c3fbde9cf6ce46d01264f963059a4c5`). The maintainer accidentally selected all four repository objects instead of only `TABL ZTOAD`; this was safe because the archive's `PROG ZTOAD` was exact current `master` and `TRAN`/`SUSO` were unchanged. The later `DEVC` deletion proposal was not selected or applied.
+- ARC-1 then explicitly activated `TABL ZTOAD` and `PROG ZTOAD`. The table reads as `#NOT_EXTENSIBLE` with the same seven fields, `PROG ZTOAD` syntax has zero errors, all 67 Unit tests pass, `DEFAULT` ATC remains 88 findings (3 P1, 4 P2, 81 P3, including the known time-zone prerequisite finding), and the global inactive inventory contains no ZTOAD part.
+- NPL's direct active-table object-state endpoint intermittently returns 404 even though the transparent table is searchable, activated, and readable through ARC-1's automatic version resolution. The compensating evidence is the explicit activation result, active automatic read, inactive-version response stating that no inactive draft exists, exact category/field comparison, and zero ZTOAD entries in the global inactive inventory. This is an ARC-1 adapter finding, not a product gate failure.
diff --git a/docs/research/2026-08-07-arc1-abapgit-integration-audit.md b/docs/research/2026-08-07-arc1-abapgit-integration-audit.md
index 7d55240..feea68b 100644
--- a/docs/research/2026-08-07-arc1-abapgit-integration-audit.md
+++ b/docs/research/2026-08-07-arc1-abapgit-integration-audit.md
@@ -23,6 +23,7 @@ _Observed 2026-08-06 to 2026-08-07 with ARC-1 1.0.2, A4H SAP_BASIS 758 SP02, nat
10. **Published MCP schemas can lag the installed CLI.** The connected SAPGit MCP contract exposed only read actions while the local ARC-1 1.0.2 CLI supported `stage`, `push`, and `switch_branch`; the same skew hid newer diagnostic actions. Publish the running server/client version in discovery, keep action enums generated from one source, and fail with an explicit upgrade/reload instruction instead of forcing callers to discover CLI-only capabilities experimentally.
11. **The installed backend's XML namespaces are not modeled correctly.** Its stage response uses `http://www.sap.com/adt/abapgit/staging`, so ARC-1 returned an empty object list even though raw XML contained `PROG` and `TABL`. ARC-1's push builder emitted a different generic `` payload, and its pull builder used singular `/repository` instead of the backend-required plural `/repositories` namespace. Version or discover the bridge contract, parse the staging namespace, preserve its staged-object shape, and add integration fixtures for this backend version.
12. **`SAPWrite(dryRun=true)` mutated TABL state.** The call returned “Successfully updated” and created an inactive `TABL ZTOAD` draft. A dry run must never acquire/save a draft; until fixed, callers must compare active/inactive state after every DDIC dry-run request and clean up or deliberately continue only after reviewing the exact draft.
+13. **NPL table object-state does not reuse endpoint discovery.** On SAP_BASIS 750, `SAPDiagnose(action="object_state", type="TABL")` requests the active table-source path and returns 404 for the installed transparent table, while `SAPRead(version="auto")`, `SAPRead(version="inactive")`, search, activation, and native abapGit all resolve it. Reuse the same table-versus-structure/version fallback in object-state diagnostics and cover this with a 7.50 integration fixture.
## Safe workflow until those gaps are fixed
@@ -33,6 +34,7 @@ _Observed 2026-08-06 to 2026-08-07 with ARC-1 1.0.2, A4H SAP_BASIS 758 SP02, nat
5. Treat native abapGit as the complete serializer and ARC-1 source writes as source-only unless the exact child-object closure is independently proven.
6. After activation, require active/inactive main equality plus the global inactive-child inventory for `PROG/P`, `PROG/PCA`, `PROG/PS`, and `PROG/PX`.
7. Treat `dryRun` as untrusted on current TABL writes and verify object state immediately. When the bridge wrapper returns an empty stage for known drift, inspect the raw staging document before taking any push action.
+8. On 7.50, if direct table object-state returns 404, do not call the object absent until automatic and inactive-version reads, exact metadata, object search, explicit activation, and the global inactive inventory have been reconciled.
## System-side conclusion
diff --git a/docs/research/2026-08-07-base-ddic-001-enhancement-category.md b/docs/research/2026-08-07-base-ddic-001-enhancement-category.md
index 8928c45..3836501 100644
--- a/docs/research/2026-08-07-base-ddic-001-enhancement-category.md
+++ b/docs/research/2026-08-07-base-ddic-001-enhancement-category.md
@@ -49,4 +49,6 @@ Reference: [abapGit TABL DDL serializer](https://github.com/abapGit/abapGit/blob
- A4H active candidate: `#NOT_EXTENSIBLE`, all seven fields unchanged, equal active/inactive table source, zero inactive ZTOAD parts, report syntax 0 errors plus two pre-existing POSIX warnings, and 67/67 Unit. `S4HANA_READINESS_2023` again returned zero rows with its known prerequisite limitation; Cloud ATC remained the unchanged legacy baseline.
- The current serializer also added `MASTERLANG E` and removed redundant per-field `TABNAME`, `POSITION`, and `DDLANGUAGE` values. Field order, names, types, key, table class, delivery class, and technical settings are unchanged. This canonicalization is reviewed as part of the dedicated structural change.
- Native abapGit staged only `TABL ZTOAD`; the pre-merge report drift was explicitly left unselected. A4H was then switched and pulled back to full `refs/heads/master`, activating current master report source and the pre-change unclassified table with equal active/inactive state.
-- Exact NPL import archive: `/tmp/ztoad-base-ddic-001.zip`, SHA-256 `a5c5745c55304e34f334ddb6b1e4ec7c4c3fbde9cf6ce46d01264f963059a4c5`. Only `TABL ZTOAD` is to be selected in the offline pull dialog; source will be synchronized separately through ARC-1.
+- Exact NPL import archive: `/tmp/ztoad-base-ddic-001.zip`, SHA-256 `a5c5745c55304e34f334ddb6b1e4ec7c4c3fbde9cf6ce46d01264f963059a4c5`. The archive was imported into the existing `$ZTOAD2` offline repository. All four repository objects were accidentally selected; this did not widen the candidate because its program was exact current `master` and its transaction/authorization object were unchanged. The subsequent package-deletion proposal was left unselected.
+- NPL explicitly activated both `TABL ZTOAD` and `PROG ZTOAD`. The active table reports `#NOT_EXTENSIBLE` with the original seven fields, the report has zero syntax errors and 67/67 passing Unit tests, `DEFAULT` ATC remains at its complete 88-finding baseline (3 P1, 4 P2, 81 P3), and the inactive inventory contains no ZTOAD object.
+- ARC-1 1.0.2's direct `TABL` active object-state path returned 404 on NPL even while its automatic table read returned the active object and its inactive read explicitly reported that no inactive draft exists. Explicit activation, both reads, exact field/category comparison, object search, and the global inactive inventory jointly establish the state; the inconsistent endpoint is tracked as an ARC-1 adapter limitation.
diff --git a/system-info.md b/system-info.md
index c7f6d5a..be36c47 100644
--- a/system-info.md
+++ b/system-info.md
@@ -97,9 +97,9 @@ The first request created during setup, `A4HK906377`, is an empty local request
| ARC-1 | Separate `arc-1-750` profile, pinned to ARC-1 1.0.2; package ceiling configured as `*`; data preview and free SQL disabled |
| UI boundary | No FLP, WebGUI, SAP GUI, or browser automation for validation; A4H owns UI smoke |
| ZTOAD state | Complete object set provisioned through native abapGit 1.134.0 offline repository in local package `$ZTOAD2`: PROG, real transparent TABL, TRAN, and SUSO |
-| Structural warning | Table enhancement category was absent; NPL activated and normalized it to `#NOT_CLASSIFIED`, leaving a diff tracked as `BASE-DDIC-001` |
-| Completion status | Exact candidate `9e8d881`: syntax 0 errors, 67/67 Unit, ATC `DEFAULT` 88 unchanged findings, equal active/inactive source, zero inactive ZTOAD parts |
-| Shared target after evidence | Restored and activated to `origin/master` `d532b2e`, server SHA-256 `e32d7d3b8bebdb38457cd81f52e90a3b00dc0e830ac537b7690b70cee4544897`; the known pre-fix fixture reproduces at 66/67 until the PR merges |
+| Structural state | BASE-DDIC-001 candidate is active as `#NOT_EXTENSIBLE`; all seven table fields are unchanged and the offline serializer warning is resolved |
+| Completion status | Exact native candidate `4206a1a`: explicit table/report activation, syntax 0 errors, 67/67 Unit, complete `DEFAULT` ATC 88 unchanged findings (3 P1, 4 P2, 81 P3), and zero inactive ZTOAD parts |
+| ARC-1 table-state caveat | Direct active `TABL` object-state returns 404 on this 7.50 endpoint; automatic and inactive-version reads resolve the active table and report no inactive draft. Explicit activation, exact metadata comparison, search, and the global inactive inventory are the compensating evidence. |
See [the NPL ADT-only validation dossier](docs/research/2026-08-06-npl-adt-only-validation.md) and the [BASE-BUG-001 grammar investigation](docs/research/2026-08-07-base-bug-001-npl-count-grammar.md). No stub DDIC structure may be used to claim compatibility.
From 424a5172534ff365006ccfbb598f8d554156aba9 Mon Sep 17 00:00:00 2001
From: marianfoo <13335743+marianfoo@users.noreply.github.com>
Date: Fri, 7 Aug 2026 11:07:09 +0200
Subject: [PATCH 5/5] docs: close BASE-DDIC-001 plan
---
.../{ => finished}/base-ddic-001-enhancement-category.md | 9 +++++++++
1 file changed, 9 insertions(+)
rename docs/plans/{ => finished}/base-ddic-001-enhancement-category.md (79%)
diff --git a/docs/plans/base-ddic-001-enhancement-category.md b/docs/plans/finished/base-ddic-001-enhancement-category.md
similarity index 79%
rename from docs/plans/base-ddic-001-enhancement-category.md
rename to docs/plans/finished/base-ddic-001-enhancement-category.md
index c3f933b..eb15d9f 100644
--- a/docs/plans/base-ddic-001-enhancement-category.md
+++ b/docs/plans/finished/base-ddic-001-enhancement-category.md
@@ -67,3 +67,12 @@ Restore `TABL ZTOAD` from the reviewed `master` serialization through native aba
- NPL imported `/tmp/ztoad-base-ddic-001.zip` (SHA-256 `a5c5745c55304e34f334ddb6b1e4ec7c4c3fbde9cf6ce46d01264f963059a4c5`). The maintainer accidentally selected all four repository objects instead of only `TABL ZTOAD`; this was safe because the archive's `PROG ZTOAD` was exact current `master` and `TRAN`/`SUSO` were unchanged. The later `DEVC` deletion proposal was not selected or applied.
- ARC-1 then explicitly activated `TABL ZTOAD` and `PROG ZTOAD`. The table reads as `#NOT_EXTENSIBLE` with the same seven fields, `PROG ZTOAD` syntax has zero errors, all 67 Unit tests pass, `DEFAULT` ATC remains 88 findings (3 P1, 4 P2, 81 P3, including the known time-zone prerequisite finding), and the global inactive inventory contains no ZTOAD part.
- NPL's direct active-table object-state endpoint intermittently returns 404 even though the transparent table is searchable, activated, and readable through ARC-1's automatic version resolution. The compensating evidence is the explicit activation result, active automatic read, inactive-version response stating that no inactive draft exists, exact category/field comparison, and zero ZTOAD entries in the global inactive inventory. This is an ARC-1 adapter finding, not a product gate failure.
+
+## Post-green process audit
+
+- GitHub Actions run `31164462265` checked the merge candidate, installed the pinned dependency set, and passed abaplint with zero issues plus the repository and installation contracts. The external abaplint check also passed.
+- The implementation remains limited to the native serializer output and its exact contract; the canonical metadata removals were generated by native abapGit and reviewed field by field rather than accepted as an unexamined XML rewrite.
+- Both supported-release gates were performed against the exact serialized candidate. The broader NPL import was compared with the archive before it was accepted, and the dangerous system-local package deletion proposal was not applied.
+- The durable workflow improvement is now in `docs/development.md`: structural-only offline pulls select only their intended object, `DEVC $ZTOAD2` deletion remains unselected, and an accidental broad selection requires an exact archive comparison before any further pull.
+- The inconsistent NPL table object-state endpoint is recorded separately as `BASE-TOOL-005` and in the ARC-1 integration audit. It is compensated by independent evidence rather than misreported as a passing object-state call.
+- No CI workflow change is needed: the existing quality job exercised the new repository contract on the merge commit and produced complete, readable output.