Skip to content

Commit aa2ec78

Browse files
committed
docs: record final P0 integration evidence
1 parent 478f91e commit aa2ec78

3 files changed

Lines changed: 18 additions & 10 deletions

File tree

‎docs/baseline-findings.md‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ This is the ordered work list for incremental TDD. It records observed defects s
99
| Gate | Result | Interpretation |
1010
|---|---|---|
1111
| Repository `npm test` | Passed, 0 configured abaplint findings | Fast compatibility/XML gate is green |
12-
| Pinned abaplint default profile | Exact combined count pending post-rebase validation | Configured abaplint remains the merge gate; diagnostic debt will be recomputed rather than copied from either branch |
13-
| A4H SAP syntax | Exact combined result pending post-rebase validation | The complete rebased source must be activated and checked |
14-
| A4H ABAP Unit | Exact combined result pending post-rebase validation | The combined suite covers all three P0 security fixes |
12+
| Pinned abaplint default profile | 2,030 findings across 59 rules | Configured abaplint remains at zero and is the merge gate; the full default profile is a diagnostic debt inventory |
13+
| A4H SAP syntax | 0 errors, 2 POSIX warnings | The exact integrated source activated successfully; both warnings are pre-existing compatibility findings |
14+
| A4H ABAP Unit | 55 passed, 0 failed | The combined suite covers all three P0 security fixes |
1515
| A4H ATC `S4HANA_READINESS_2023` | Initial run displayed 0 finding rows | Later evidence shows missing prerequisites; this is not an authoritative zero gate |
16-
| A4H ATC `ABAP_CLOUD_READINESS` | Exact combined result pending post-rebase validation | Branch-local ATC totals are invalid after integration |
17-
| A4H WebGUI smoke | Exact combined result pending post-rebase validation | Startup will be repeated without SQL execution; missing `STATUS010` remains `BASE-BUG-007` |
16+
| A4H ATC `ABAP_CLOUD_READINESS` | 668 findings: 462 P1, 206 P2 | Architectural burn-down signal; not a zero gate |
17+
| A4H WebGUI smoke | Fresh editor/DDIC startup passed; no browser error, SQL execution, or ST22 delta | Missing `STATUS010` remains independently tracked as `BASE-BUG-007` |
1818
| ABAP 7.50 live gate | ARC-1 lifecycle passed; ZTOAD blocked | `arc-1-750` can create/activate/syntax/unit/delete, but ZTOAD's transparent table is absent and SAP_BASIS 750 cannot create it over ADT |
1919

20-
BASE-SEC-002 and BASE-SEC-001 are merged and their complete production/test corpus is preserved in this candidate. Exact syntax, Unit, ATC, source-hash, and smoke evidence for the combined BASE-SEC-003 candidate must be recomputed before merge. See the [finished BASE-SEC-003 plan](plans/finished/base-sec-003.md), [finished BASE-SEC-001 plan](plans/finished/base-sec-001.md), and [BASE-SEC-002 research](research/2026-08-06-base-sec-002-native-sql.md).
20+
BASE-SEC-002 and BASE-SEC-001 are merged and their complete production/test corpus is preserved in this candidate. The exact integrated source SHA-256 `339a53f579fcde6b95dee08841a421fbe510839d06113902c800b6c28eee5397` matched the activated A4H source at server-normalized SHA-256 `46789b7a44ac06953e9a69a03f19199d6192ebf10327aa24c3e13c77d1e9c654`. Coverage was 25.07% statements, 24.10% branches, and 16.87% procedures. `S4HANA_READINESS_2023` returned no rows but remains incomplete because its prerequisite checks are unavailable. See the [finished BASE-SEC-003 plan](plans/finished/base-sec-003.md), [finished BASE-SEC-001 plan](plans/finished/base-sec-001.md), and [BASE-SEC-002 research](research/2026-08-06-base-sec-002-native-sql.md).
2121

2222
## Ordered findings register
2323

@@ -26,9 +26,9 @@ Priority meanings: **P0** blocks the requested test workflow or is an immediate
2626
| ID | Pri. | Finding and evidence | Test to drive the fix | Status |
2727
|---|---:|---|---|---|
2828
| BASE-RUN-001 | P0 | ZTOAD originally dumped in WebGUI through `DP_PUBLISH_URL`; a rejected SQL-mode spike then dumped in `CL_GUI_SOURCEEDIT`. The final adapter uses `CL_GUI_TEXTEDIT` in WebGUI and keeps `CL_GUI_ABAPEDIT` elsewhere. | Two editor-policy Unit tests plus fresh WebGUI launch/input and post-run ST22 delta. | Fixed candidate: 19/19 green, editor renders and accepts input, no new dump; full query dispatch waits on `BASE-BUG-007` |
29-
| BASE-SEC-001 | P0 | User text reached both generated-program sinks, and the original code accepted a harmless `.<space>WRITE sy-uname` statement-injection proof as valid ABAP. External review also confirmed that the 255-character hard cut could split a doubled quote while still producing a pool. | Direct SELECT/DML generator regressions plus a pure boundary matrix for literals, decimals, operators, comments, host escapes, templates, chained statements, unbalanced quotes, namespace-shaped period lookalikes, and safe generated-line wrapping. | Fixed candidate: exact post-#18 source is 40/40 green on A4H; unsafe fragments/layouts return no pool and no SQL was executed |
29+
| BASE-SEC-001 | P0 | User text reached both generated-program sinks, and the original code accepted a harmless `.<space>WRITE sy-uname` statement-injection proof as valid ABAP. External review also confirmed that the 255-character hard cut could split a doubled quote while still producing a pool. | Direct SELECT/DML generator regressions plus a pure boundary matrix for literals, decimals, operators, comments, host escapes, templates, chained statements, unbalanced quotes, namespace-shaped period lookalikes, and safe generated-line wrapping. | Fixed and merged in PR #20; inherited by this 55/55 integrated candidate |
3030
| BASE-SEC-002 | P0 | Native SQL used unsupported kernel call `C_DB_EXECUTE`. It was a high-impact arbitrary database-command path and produced a live compiler warning. | Default rejection, rejection despite the deprecated enable flag, preserved UPDATE/DELETE parsing, and a no-kernel-call repository contract. | Fixed and merged in PR #18; inherited by this candidate |
31-
| BASE-SEC-003 | P0 | SELECT authorization extraction tokenized top-level `FROM`/`JOIN` text and could miss nested subqueries/CTEs or concealed data sources. A quote-aware scanner now applies the existing policy to every provable physical source and rejects unprovable dynamic/CTE/comment/path/hierarchy syntax, including attached path tokens. | Multi-table joins, nested subqueries, aliases, literal keywords, scanner-level comment rejection, `UNION`/`UNION ALL` sources, attached/detached paths, hierarchy/keyword lookalikes, and unauthorized inner-table cases. | Fixed candidate; parenthesized joins deliberately fail closed and exact combined evidence is pending after rebase |
31+
| BASE-SEC-003 | P0 | SELECT authorization extraction tokenized top-level `FROM`/`JOIN` text and could miss nested subqueries/CTEs or concealed data sources. A quote-aware scanner now applies the existing policy to every provable physical source and rejects unprovable dynamic/CTE/comment/path/hierarchy syntax, including attached path tokens. | Multi-table joins, nested subqueries, aliases, literal keywords, scanner-level comment rejection, `UNION`/`UNION ALL` sources, attached/detached paths, hierarchy/keyword lookalikes, and unauthorized inner-table cases. | Fixed candidate: exact integrated source is 55/55 green on A4H; parenthesized joins deliberately fail closed |
3232
| BASE-BUG-001 | P1 | [Issue #6](https://github.com/marianfoo/ztoad/issues/6): a reported `SELECT DISTINCT ... COUNT ... MAX ... GROUP BY ... HAVING` query produces “The INTO/APPENDING clause must be at the end of the SELECT.” | Sanitized `DD03L` reproduction; check exact generated ordering around `HAVING`, `ORDER BY`, `UP TO`, and `INTO TABLE`. | Fixed and 17/17 green on A4H; live 7.50 pending |
3333
| BASE-BUG-002 | P1 | [Issue #7](https://github.com/marianfoo/ztoad/issues/7): a reported `SUM( CASE ... END ) AS ...` over `EKBE` produces “No component exists with the name CASE.” The expression is split into false result components. | Sanitized aggregate with multi-line `CASE`, qualified fields, multiplication, alias, WHERE, and GROUP BY; assert one aggregate expression and the expected generated row type. | Open |
3434
| BASE-BUG-003 | P1 | [Issue #4](https://github.com/marianfoo/ztoad/issues/4): `SUBSTRING`/`CONCAT` produce “No component exists with the name SUBSTRING(”, exposing naïve select-list tokenization. | Nested function arguments, commas inside functions, aliases, literals containing spaces/commas, and function composition. | Open |

‎docs/development.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ Run these checks for the complete ZTOAD object set on both systems:
146146
2. All imported objects activate.
147147
3. SAP syntax check passes for program `ZTOAD`.
148148
4. ABAP Unit passes with no skipped relevant tests.
149-
5. ATC completes with the recorded project variants and has no new unapproved finding. The latest A4H `S4HANA_READINESS_2023` run returned no finding rows but was incomplete because seven prerequisite checks are unavailable. The latest `ABAP_CLOUD_READINESS` run reported 768 architectural findings (463 P1, 305 P2); it is an information/burn-down signal, not a zero gate.
149+
5. ATC completes with the recorded project variants and has no new unapproved finding. A `S4HANA_READINESS_2023` run with unavailable prerequisite checks is incomplete even when it returns no finding rows. Treat `ABAP_CLOUD_READINESS` as an architectural information/burn-down signal, not a zero gate; record exact dated totals in the [baseline findings register](baseline-findings.md), not this long-lived playbook.
150150
6. Manual read-only browser smoke tests pass on A4H; NPL UI smoke is not applicable by maintainer direction.
151151
7. Authorization-negative tests confirm that unauthorized tables/activities remain blocked.
152152
8. ST22 and, when relevant, Gateway/system logs contain no new errors from the test.
@@ -176,7 +176,7 @@ Then exercise the parser feature being changed with a sanitized query and verify
176176

177177
`BASE-RUN-001` is fixed at the editor boundary: a fresh A4H WebGUI launch renders the fallback editor, accepts the sanitized query, and creates no new ST22 dump. Full query execution is still not green because the current A4H installation lacks GUI status `STATUS010` (`BASE-BUG-007`). Keep product behavior failures separate from incomplete system metadata, and never run this browser protocol on NPL.
178178

179-
Use `npm run lint:quality` to reproduce the non-blocking full default-rule inventory. `master` has 1,857 findings; the BASE-RUN-001 candidate has 1,878, with 19 adapter-API naming diagnostics plus 2 classic-exception diagnostics needed to preserve the legacy Control Framework `sy-subrc` contract. The raw defaults contain conflicting prefix/no-prefix naming rules, so the strict profile must resolve that configuration conflict explicitly while the raw inventory remains visible. Continue the [active zero-findings plan](plans/abaplint-zero-findings.md); only promote the resolved strict command to required CI after it is green.
179+
Use `npm run lint:quality` to reproduce the non-blocking full default-rule inventory. Record exact dated totals and intentional deltas in the [baseline findings register](baseline-findings.md); do not copy volatile counts into this long-lived playbook. The raw defaults contain conflicting prefix/no-prefix naming rules, so the strict profile must resolve that configuration conflict explicitly while the raw inventory remains visible. Continue the [active zero-findings plan](plans/abaplint-zero-findings.md); only promote the resolved strict command to required CI after it is green.
180180

181181
## 8. Security review for every parser/execution change
182182

‎docs/plans/finished/base-sec-003.md‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,3 +52,11 @@ Close the nested-source authorization bypass by identifying and checking every p
5252
- Post-green audit: the red/green/live/final-review sequence caught the generated-source comment boundary before publication. The durable improvement is an explicit representation-boundary review in `AGENTS.md`, this playbook, and the PR template; long-lived docs no longer hard-code a test count that becomes stale. The Quality workflow itself is correctly scoped, pinned, cached, and green, so no CI code change was justified.
5353
- Post-audit CI: GitHub Actions run `31105030456` passed on head `c14ba791bfc015d58f1ff5953460debd05f06378`. The subsequent full-grammar review added fail-closed path-expression and hierarchy cases. GitHub Actions run `31105406732` then passed on implementation/evidence head `8bba88d`; this final evidence-only commit requires the last green head check before readiness.
5454
- External review replay: SAP Docs MCP confirmed that a data-source path expression attaches directly to its exposed unit. A test-only A4H replay passed 32/34 tests and failed exactly `REJECTS_ATTACHED_PATH_SOURCE` and `ACCEPTS_HIERARCHY_NAMED_TABLE` against the previous implementation. Rejecting `\` anywhere in the source token and matching only the exact `HIERARCHY` constructor turned the same suite green at 34/34. The exact final source SHA-256 `88bbed3e82eeff672bbbdf74eaa710a8749de391362fc5f7870843971b6d38c9` activated with zero syntax errors and four known warnings; active/inactive source matched at server-normalized SHA-256 `ecb1d3c5495716c30305ab3c4a96b83082d69c89d151e9035464e2ea7c2c7fec`. Coverage remained 18.69% statements, 18.57% branches, and 8.97% procedures. `ABAP_CLOUD_READINESS` returned 769 findings (464 P1, 305 P2), and `S4HANA_READINESS_2023` returned no rows but remains incomplete. The added parenthesized-join test records the intentional compatibility limitation; the `UNION ALL` test confirms its later unauthorized source was already seen by the full-input scanner.
55+
56+
## Post-PR #18/#20 integration validation
57+
58+
- The branch was rebased after PR #18 removed Native SQL and PR #20 hardened both generated-program sinks. Conflicts were resolved semantically and the complete predecessor production/test corpus was retained.
59+
- The exact integrated source SHA-256 `339a53f579fcde6b95dee08841a421fbe510839d06113902c800b6c28eee5397` passed repository tests, configured abaplint with zero findings, A4H server preflight, activation, syntax, ABAP Unit, active/inactive comparison, ATC, and the safe browser smoke. The server-normalized source SHA-256 was `46789b7a44ac06953e9a69a03f19199d6192ebf10327aa24c3e13c77d1e9c654`.
60+
- A4H syntax reported zero errors and two pre-existing POSIX warnings. All 55 ABAP Unit tests passed. Coverage was 25.07% statements, 24.10% branches, and 16.87% procedures.
61+
- `ABAP_CLOUD_READINESS` returned 668 findings (462 P1, 206 P2). `S4HANA_READINESS_2023` returned no rows but remains incomplete because its prerequisite checks are unavailable. The diagnostic full abaplint profile reported 2,030 findings across 59 rules and remains non-blocking; configured abaplint remains the zero-findings merge gate.
62+
- A fresh A4H FLP/WebGUI startup rendered the editor and DDIC pane with no browser error. No SQL was executed and the before/after ST22 identifiers were identical. Missing GUI status `STATUS010` remains the independent `BASE-BUG-007` installation finding.

0 commit comments

Comments
 (0)