Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom flag to identify regular transactions #2

Open
maread99 opened this issue Nov 17, 2022 · 1 comment
Open

Use custom flag to identify regular transactions #2

maread99 opened this issue Nov 17, 2022 · 1 comment
Labels
code improvement Efficiency improvement, efficacy unchanged (refactoring, speed improvements etc)

Comments

@maread99
Copy link
Owner

maread99 commented Nov 17, 2022

Currently regular transactions are flagged '!' and tagged 'reg_txn'. The tag allows them to be identified. It might be preferable for a custom flag to do this job although the lexer for beancount v2 is hardcoded to only recognize flags defined in beancount.core.flags. If beancount v3 provides for custom flags consider using flags to identify expected transactions, for example, 'XR' for a regular expected transaction.

(EDIT Jun 24) HOWEVER, would need to maintain v2 compatibility until v3 becomes established. i.e. this is perhaps something to consider only when it'd be reasonable to drop support for v2.

@maread99 maread99 added the TODO What it says on the tin label Nov 17, 2022
@blaggacao
Copy link

blaggacao commented May 1, 2024

regular transactions are flagged '!'

I think that is not actually working, maybe it is the reason why those transactions are still subject to duplicate detection and I had to implement https://github.com/maread99/beanahead/pull/16/files#diff-f6d54813d78a276ac3cd1b222af073eef6386d04bbade282405f4820b8f66126R65 ?

@maread99 maread99 added code improvement Efficiency improvement, efficacy unchanged (refactoring, speed improvements etc) and removed TODO What it says on the tin labels Jun 28, 2024
@maread99 maread99 changed the title TODO for beancount v3 Use custom flag to identify regular transactions Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code improvement Efficiency improvement, efficacy unchanged (refactoring, speed improvements etc)
Projects
None yet
Development

No branches or pull requests

2 participants