t5494: remove legacy key mappings for contribution_watch and draft_responses#5502
t5494: remove legacy key mappings for contribution_watch and draft_responses#5502marcusquinn wants to merge 2 commits intomainfrom
Conversation
…onses Both keys were added to _legacy_key_to_dotpath in PR #5466 for new features that were introduced with namespaced keys from the start. Legacy mappings are for backward compatibility with old flat keys — not for new features. - Remove contribution_watch → orchestration.contribution_watch mapping - Remove draft_responses → orchestration.draft_responses mapping - Update setup.sh to call is_feature_enabled with namespaced dotpaths directly Addresses Gemini medium-severity finding at config-helper.sh:384 (GH#5494). Closes #5494
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the configuration key management system by correcting how new feature flags are handled. It removes unnecessary legacy mappings for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Sun Mar 22 18:30:07 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly removes legacy key mappings for the contribution_watch and draft_responses features from config-helper.sh. Since these are new features introduced with namespaced keys, the backward-compatibility layer was unnecessary. The changes in setup.sh appropriately update the calls to is_feature_enabled to use the full dot-path keys directly. This refactoring improves code clarity and maintainability by removing the unneeded indirection.
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Tue Mar 24 09:07:22 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
|
Closing: merge conflicts with main after reopening. The changes need to be rebased or re-implemented in a fresh branch. |
2 participants
Summary
contribution_watchanddraft_responsesfrom_legacy_key_to_dotpathinconfig-helper.sh— these were new features introduced with namespaced keys in PR t1554: Auto-install contribution-watch launchd service on setup/update #5466, not old flat keys needing backward-compat mappingsetup.shto callis_feature_enabledwith the full dotpath (orchestration.contribution_watch,orchestration.draft_responses) directly, eliminating the need for the legacy mappingFindings addressed
Medium-severity finding from Gemini code review on PR #5466:
config-helper.sh:384—contribution_watchadded to_legacy_key_to_dotpathfor a new feature; legacy mappings are for backward compatibility with old flat keys, not new namespaced features. Same pattern applied todraft_responsesat line 385.Verification
config-helper.shandsetup.shis_feature_enabled orchestration.contribution_watchresolves correctly via the dotpath lookup path (no legacy mapping needed)Closes #5494