add pre-commit with basic hooks

Author: leo-schick

.gitignore

@@ -123,4 +123,4 @@ dmypy.json
 .pyre/
 
 # Editors/IDEs
-/.idea/
+/.idea/

.pre-commit-config.yaml

@@ -0,0 +1,11 @@
+# See https://pre-commit.com for more information
+# See https://pre-commit.com/hooks.html for more hooks
+repos:
+-   repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v3.2.0
+    hooks:
+    -   id: trailing-whitespace
+    -   id: end-of-file-fixer
+    -   id: check-toml
+    -   id: check-yaml
+    -   id: check-added-large-files

LICENSE

@@ -16,4 +16,4 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
+SOFTWARE.

Makefile

@@ -30,4 +30,4 @@ clean:
 	mkdir -p .venv
 	cd .venv && $(.PYTHON3) -m venv --copies --prompt='[$(shell basename `pwd`)/.venv]' .
 
-	.venv/bin/python -m pip install --upgrade pip 
+	.venv/bin/python -m pip install --upgrade pip

docs/api.rst

@@ -29,4 +29,4 @@ Superset API Client
 
 .. autoclass:: SupersetClient
    :members:
-   :inherited-members:
+   :inherited-members:

docs/changes.rst

@@ -1 +1 @@
-.. include:: ../CHANGELOG.rst
+.. include:: ../CHANGELOG.rst

docs/config.rst

@@ -61,7 +61,7 @@ and can be changed with the `monkey patch`_ from `Mara App`_. An example can be
 .. py:data:: superset_data_db_schema
 
     The name of the schema where the flattered data sets for Superset are stored
-    
+
     Default: ``'superset'``
 
 .. py:data:: metadata_update_strategy

docs/index.rst

@@ -49,4 +49,4 @@ Legal information and changelog are here for the interested.
    :maxdepth: 2
 
    license
-   changes
+   changes

docs/sync.rst

@@ -16,9 +16,9 @@ The update strategy is defined via an flag Enum ``UpdateStrategy`` which support
     When the model does not exist in Superset, create it
 
 .. py:data:: UPDATE
-    
+
     When the model exists already in Superset, update its columns. Columns which where removed will be retained and return a 'NULL' value.
-    
+
     .. warning::
         New columns are (currently) not added automatically. You need to run schema sync. manually in Superset and then run the metadata sync again.
         This might drop columns which does not exist anymore leaving existing charts in an inconsistent state (!).

mara_superset/.scripts/superset.mk

@@ -38,4 +38,4 @@ install-superset:
 # remove virtual env for superset
 .cleanup-superset:
 	rm -rf .superset
-	rm -f .venv/bin/superset
+	rm -f .venv/bin/superset

mara_superset/__init__.py

@@ -18,4 +18,4 @@ def MARA_ACL_RESOURCES():
 
 def MARA_NAVIGATION_ENTRIES():
     from . import views
-    return {'Superset': views.navigation_entry()}
+    return {'Superset': views.navigation_entry()}

mara_superset/cli.py

@@ -5,4 +5,4 @@
 def update_metadata():
     """Sync schema definitions from Mara to Superset"""
     from . import metadata
-    metadata.update_metadata()
+    metadata.update_metadata()

mara_superset/client.py

@@ -7,7 +7,7 @@
 class SupersetClient(object):
     """
     A client class for interacting with the Superset API
-    
+
     See also: https://superset.apache.org/docs/api
     """
     def __init__(self):
@@ -65,4 +65,4 @@ def put(self, path, data=None) -> dict:
         return self.request(self.session.put, path, data)
 
     def delete(self, path, data=None) -> dict:
-        return self.request(self.session.delete, path, data)
+        return self.request(self.session.delete, path, data)

mara_superset/metadata.py

@@ -36,7 +36,7 @@ class UpdateStrategy(Flag):
 def update_metadata(update_strategy: UpdateStrategy = None) -> bool:
     """
     Updates descriptions of tables & fields in Superset, creates metrics and flushes field caches
-    
+
     Args:
         update_strategy: How the metadata should be updated. If not defined the value from config.metadata_update_strategy().
     """
@@ -179,7 +179,7 @@ def delete_dataset_metadata(data_set_id):
                     update_dataset_metadata(data_set, data_set_id=data_set_id)
 
                 # removes the entity from the dict so we leave at the end only the
-                # data sets in the dict which are not 
+                # data sets in the dict which are not
                 del data_sets[data_set_metadata['table_name']]
             elif bool(update_strategy & UpdateStrategy.DELETE):
                 if not data_set.get('is_sqllab_view',False):

mara_superset/views.py

@@ -19,4 +19,4 @@ def navigation_entry():
 def superset():
     from . import config
 
-    return flask.redirect(config.external_superset_url())
+    return flask.redirect(config.external_superset_url())

setup.py

@@ -1,3 +1,3 @@
 from setuptools import setup
 
-setup()
+setup()