Better error reporting #5266
Merged
Better error reporting #5266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5266 +/- ##
==========================================
- Coverage 91.84% 91.81% -0.03%
==========================================
Files 281 282 +1
Lines 38856 38898 +42
Branches 6793 6818 +25
==========================================
+ Hits 35686 35715 +29
- Misses 3043 3055 +12
- Partials 127 128 +1 ☔ View full report in Codecov by Sentry. |
ibesora
commented
Dec 24, 2024
HarelM
reviewed
Dec 24, 2024
HarelM
reviewed
Dec 24, 2024
HarelM
reviewed
Dec 24, 2024
HarelM
reviewed
Dec 24, 2024
HarelM
reviewed
Dec 24, 2024
HarelM
reviewed
Dec 24, 2024
|
One small nit picking left. |
HarelM
reviewed
Dec 26, 2024
src/ui/map.ts
Outdated
| const globeRenderingChaged = this.style.projection.transitionState > 0 !== isGlobeRendering; | ||
| this.style.projection.setErrorQueryLatitudeDegrees(this.transform.center.lat); | ||
| this.transform.setTransitionState(this.style.projection.transitionState, this.style.projection.latitudeErrorCorrectionRadians); | ||
| const globeRenderingChaged = this.style.projection?.transitionState > 0 !== isGlobeRendering; |
There was a problem hiding this comment.
Chaged should be changed, not fully related to this change obviously...
HarelM
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids suppressing any error that's not an abort error or a "Framebuffer not complete" error.
While doing that I found multiple instances of errors that were being thrown and swallowed across the codebase and had to fix some tests.
Launch Checklist
CHANGELOG.mdunder the## mainsection.