Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete test/integration/render/tests/projection/globe/terrain/fill-planet-pole directory #5208

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Dec 15, 2024

This is due to the fact that the test is flaky.
The following are tracking issue that can maybe use the content of the style.json in the PR for future render tests (or simply add the relevant test they need after the issues are fixed).

@HarelM HarelM requested review from ibesora and birkskyum December 15, 2024 15:08
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.82%. Comparing base (414e474) to head (fe56f64).
Report is 11 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5208   +/-   ##
=======================================
  Coverage   91.82%   91.82%           
=======================================
  Files         281      281           
  Lines       38786    38786           
  Branches     6760     6762    +2     
=======================================
  Hits        35614    35614           
  Misses       3044     3044           
  Partials      128      128           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM HarelM merged commit 4a50534 into main Dec 16, 2024
17 checks passed
@HarelM HarelM deleted the remove-flaky-test branch December 16, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests\projection\globe\terrain\fill-planet-pole test is not stable
2 participants