Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated mac server address in dev docs #38465

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RabiyaF
Copy link

@RabiyaF RabiyaF commented Dec 3, 2024

Description of work

Summary of work

Updates the address of the data archive server in the developer docs for mac.

Further detail of work

To test:


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@RabiyaF RabiyaF added Documentation Issues and pull requests related to documentation macOS Only The issues related to macOS only. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS labels Dec 3, 2024
@RabiyaF RabiyaF self-assigned this Dec 3, 2024
@RabiyaF RabiyaF requested a review from thomashampson December 3, 2024 16:20
@thomashampson thomashampson added this to the Release 6.12 milestone Dec 4, 2024
@RabiyaF RabiyaF force-pushed the update-server-address-in-mac-developer-docs branch 3 times, most recently from 8302066 to da4358f Compare December 11, 2024 11:25
@RabiyaF RabiyaF force-pushed the update-server-address-in-mac-developer-docs branch from da4358f to 65415b4 Compare December 11, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues and pull requests related to documentation ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS macOS Only The issues related to macOS only.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants