Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polarized SANS metadata: SaveNXcanSAS should accept workspace group inputs #38504

Open
rbauststfc opened this issue Dec 12, 2024 · 0 comments
Open
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS SANS Issues and pull requests related to SANS
Milestone

Comments

@rbauststfc
Copy link
Contributor

Part of #36147. See the design and requirements documents that are linked on that issue for more context.

The SaveNXcanSAS algorithm will only take a Matrix Workspace, however the output of a polarized SANS reduction will be a workspace group. In the code, although we plan to add a SavePolarizedNXcanSAS algorithm for reduced polarized data, I'm expecting that we will copy the InputWorkspace property for that algorithm from SaveNXcanSAS. This means we will need to change the InputWorkspace property on SaveNXcanSAS so that it will accept workspace groups.

At the moment the SANS scientists save workspace groups from non-polarized reductions (e.g. when time slicing) into separate files, but this is much less convenient for them. They would like to be able to pass a workspace group to SaveNXcanSAS and have it save all of the data into a single file. This would involve writing multiple SASData blocks into the file and I'm not sure what metadata our scientists would want us to add to distinguish each block. This is outside scope for the Polarised SANS epic, so I would recommend that we simply allow workspace groups to be passed in but internally still save them into separate files. Following further discussion with our scientists, a separate issue can be opened to look at saving multiple SASData blocks into a single file from SaveNXcanSAS.

This issue should only be worked on once #38503 has been completed.

@rbauststfc rbauststfc added SANS Issues and pull requests related to SANS ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS labels Dec 12, 2024
@rbauststfc rbauststfc added this to the Release 6.13 milestone Dec 12, 2024
@rbauststfc rbauststfc moved this to Ready for Development in ISIS Polarised SANS Reduction Dec 12, 2024
@rbauststfc rbauststfc moved this from New to Backlog in ISIS LSS Sprint Planning Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS SANS Issues and pull requests related to SANS
Projects
Status: Backlog
Status: Ready for Development
Development

No branches or pull requests

1 participant