Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bespoke input and output spin state in PolarizationCorrectionFredrikze #36981

Closed
2 tasks
rbauststfc opened this issue Mar 6, 2024 · 0 comments · Fixed by #37672
Closed
2 tasks

Allow bespoke input and output spin state in PolarizationCorrectionFredrikze #36981

rbauststfc opened this issue Mar 6, 2024 · 0 comments · Fixed by #37672
Assignees
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Reflectometry Issues and pull requests related to reflectometry
Milestone

Comments

@rbauststfc
Copy link
Contributor

rbauststfc commented Mar 6, 2024

Equivalent to #35067, but to be added to the PolarizationCorrectionFredrikze algorithm. This algorithm is not normally used by POLREF, but it would still be good to have the option to use it since it's offered as an option via the GUI.

The algorithm takes spin states directly as the input (unlike Wildes, which takes flipper configurations), so we need to add two new properties:

  • Input spin state order - for specifying the order of the spin states in the input workspace group. Users should be able to specify either pp, pa, ap, aa, in any order, or p, a in either order. The tooltip supplied should make it clear that p is parallel and a is anti-parallel in this context, to avoid confusion with the Wildes algorithm input flipper configurations. This should also be explained clearly in the documentation. For backwards compatibility, the default value should be the input order that the algorithm currently uses.
  • Output spin state order - for specifying the order of the spin states to be used for the output workspace group. Users should be able to specify either pp, pa, ap, aa, in any order, or p, a in either order. For backwards compatibility, the default value should be the output order that the algorithm currently uses.

PolarizationCorrectionFredrikze can be called via PolarizationEfficiencyCor, so PolarizationEfficiencyCor and it's documentation will need to be updated to support these changes.

Exposing the extra fields in the Reflectometry GUI will be covered separately under issue #37617.

This is part of the Polarised Reflectivity epic.

@rbauststfc rbauststfc added Reflectometry Issues and pull requests related to reflectometry ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS labels Mar 6, 2024
@rbauststfc rbauststfc moved this from New to Backlog in ISIS LSS Sprint Planning Mar 6, 2024
@rbauststfc rbauststfc added this to the Release 6.11 milestone Jun 13, 2024
@rbauststfc rbauststfc moved this from ToDo MVP to Gathering Requirements in ISIS Polarised Reflectivity epic Jun 27, 2024
@rbauststfc rbauststfc moved this from Backlog to Icebox in ISIS LSS Sprint Planning Jun 27, 2024
@rbauststfc rbauststfc added the Awaiting User Response Waiting on input or testing from a third party label Jun 27, 2024
@rbauststfc rbauststfc moved this from Icebox to Backlog in ISIS LSS Sprint Planning Jul 3, 2024
@rbauststfc rbauststfc removed the Awaiting User Response Waiting on input or testing from a third party label Jul 3, 2024
@rbauststfc rbauststfc moved this from Gathering Requirements to Ready for Development in ISIS Polarised Reflectivity epic Jul 3, 2024
@rbauststfc rbauststfc moved this from Backlog to In Progress in ISIS LSS Sprint Planning Jul 10, 2024
@rbauststfc rbauststfc changed the title Allow bespoke flipper configurations and output spin state in PolarizationCorrectionFredrikze Allow bespoke input and output spin state in PolarizationCorrectionFredrikze Jul 22, 2024
@rbauststfc rbauststfc moved this from Ready for Development to In Progress in ISIS Polarised Reflectivity epic Jul 22, 2024
@rbauststfc rbauststfc moved this from In Progress to In Review in ISIS Polarised Reflectivity epic Sep 9, 2024
@rbauststfc rbauststfc modified the milestones: Release 6.11, Release 6.12 Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Reflectometry Issues and pull requests related to reflectometry
Projects
Status: Done
2 participants