Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#35: Improve keyboard interrupt handling in iPython #38

Merged
merged 5 commits into from
Jan 5, 2018
Merged

#35: Improve keyboard interrupt handling in iPython #38

merged 5 commits into from
Jan 5, 2018

Conversation

winterjung
Copy link
Contributor

Description of changes

This PR resolve the issue #35. In an iPython, if a user rises KeyboardInterrupt without handling error statement, the cell is broken and spinner remains.

Checklist

  • Your branch is up-to-date with the base branch
  • You've included at least one test if this is a new feature
  • All tests are passing

Related Issues and Discussions

Fixed #35 refer #32

People to notify

@manrajgrover

@winterjung
Copy link
Contributor Author

@manrajgrover My windows machine's tox is working well. All tests are passed except lint. But why is there a problem on appveyor?

@manrajgrover
Copy link
Owner

Ah, I'm not sure why invocation failed. I just made a PR myself and build passed. I would need to explore it a little more. When you tested it locally on Windows, did all test pass for py27 and py36? If yes, could you please try removing the test case in this PR?

@winterjung
Copy link
Contributor Author

Yes. Test for py27 and py36 is passed. I updated PR, then appveyor is all green.

@manrajgrover
Copy link
Owner

I would need to see why the test failed on Appveyor. Currently, I don't have access to Windows machine to do the same. Please give me some time to test it on Windows machine. I'm merging this and will add test for this. I'm keeping the issue open as a reminder. Thank you for working on this. 😄 💯

manrajgrover
manrajgrover approved these changes Jan 5, 2018
View reviewed changes
Copy link
Owner

@manrajgrover manrajgrover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merging!

@manrajgrover manrajgrover merged commit 8e84336 into manrajgrover:master Jan 5, 2018
@manrajgrover manrajgrover mentioned this pull request Jan 11, 2018
Open
@winterjung winterjung deleted the fix-ipython branch January 12, 2018 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manrajgrover manrajgrover manrajgrover approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iPython notebook keyboard interrupt breaks cell when using Halo
2 participants
@winterjung @manrajgrover