Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional stripping to allow whitespacing #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

UltraWelfare
Copy link

Description of new feature, or changes

Added an optional strip parameter to the constructor of the Halo object to address the issue #113 .
By making this optional parameter False at the constructor it will no longer strip text, allowing whitespace when start function is being called with a text parameter.

Checklist

  • Your branch is up-to-date with the base branch
  • You've included at least one test if this is a new feature
  • All tests are passing

Related Issues and Discussions

FIxes #113

@coveralls
Copy link

coveralls commented Jan 20, 2019

Pull Request Test Coverage Report for Build 347

  • 9 of 10 (90.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 89.848%

Changes Missing Coverage Covered Lines Changed/Added Lines %
halo/halo.py 9 10 90.0%
Totals Coverage Status
Change from base Build 346: -0.4%
Covered Lines: 291
Relevant Lines: 316

💛 - Coveralls

@manrajgrover manrajgrover self-requested a review January 31, 2019 20:45
@manrajgrover
Copy link
Owner

@UltraWelfare Apologies for late reply. This will need test cases before getting reviewed! :)

Please let me know if you need any assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: text input ignores leading spaces
3 participants