feat: Replace ParsedPath with custom ReferencePath, support Map and Set references with arbitrary types (#491)

Author: makspll

assets/tests/add_default_component/component_with_default_and_component_data_adds_default.lua

@@ -6,4 +6,4 @@ local added = world.has_component(entity, _type)
 assert(added ~= nil, 'Component not added')
 
 local component = world.get_component(entity, _type)
-assert(component._1 == "Default", 'Component did not have default value, got: ' .. component._1)
+assert(component[1] == "Default", 'Component did not have default value, got: ' .. component[1])

assets/tests/add_default_component/component_with_default_and_component_data_adds_default.rhai

@@ -6,4 +6,4 @@ let added = world.has_component.call(entity, _type);
 assert(type_of(added) != "()", "Component not added");
 
 let component = world.get_component.call(entity, _type);
-assert(component["_0"] == "Default", "Component did not have default value, got: " + component["_0"]);
+assert(component[0] == "Default", "Component did not have default value, got: " + component[0]);

assets/tests/add_default_component/component_with_from_world_and_component_data_adds_default.lua

@@ -6,4 +6,4 @@ local added = world.has_component(entity, _type)
 assert(added ~= nil, 'Component not added')
 
 local component = world.get_component(entity, _type)
-assert(component._1 == "Default", 'Component did not have default value, got: ' .. component._1)
+assert(component[1] == "Default", 'Component did not have default value, got: ' .. component[1])

assets/tests/add_default_component/component_with_from_world_and_component_data_adds_default.rhai

@@ -6,4 +6,4 @@ let added = world.has_component.call(entity, _type);
 assert(type_of(added) != "()", "Component not added");
 
 let component = world.get_component.call(entity, _type);
-assert(component["_0"] == "Default", "Component did not have default value, got: " + component["_0"])
+assert(component[0] == "Default", "Component did not have default value, got: " + component[0])

assets/tests/construct/construct_enum.lua

@@ -6,22 +6,28 @@ local constructed = construct(type, {
     foo = 123
 })
 
-assert(constructed:variant_name() == "Struct", "Value was constructed incorrectly, expected constructed.variant to be Struct but got " .. constructed:variant_name())
-assert(constructed.foo == 123, "Value was constructed incorrectly, expected constructed.foo to be 123 but got " .. constructed.foo)
+assert(constructed:variant_name() == "Struct",
+    "Value was constructed incorrectly, expected constructed.variant to be Struct but got " .. constructed:variant_name())
+assert(constructed.foo == 123,
+    "Value was constructed incorrectly, expected constructed.foo to be 123 but got " .. constructed.foo)
 
 
 -- TupleStruct Variant
 local constructed = construct(type, {
     variant = "TupleStruct",
-    _1 = 123
+    ["1"] = 123
 })
 
-assert(constructed:variant_name() == "TupleStruct", "Value was constructed incorrectly, expected constructed.variant to be TupleStruct but got " .. constructed:variant_name())
-assert(constructed._1 == 123, "Value was constructed incorrectly, expected constructed._1 to be 123 but got " .. constructed._1)
+assert(constructed:variant_name() == "TupleStruct",
+    "Value was constructed incorrectly, expected constructed.variant to be TupleStruct but got " ..
+    constructed:variant_name())
+assert(constructed[1] == 123,
+    "Value was constructed incorrectly, expected constructed._1 to be 123 but got " .. constructed[1])
 
 -- Unit Variant
 local constructed = construct(type, {
     variant = "Unit"
 })
 
-assert(constructed:variant_name() == "Unit", "Value was constructed incorrectly, expected constructed.variant to be Unit but got " .. constructed:variant_name())
+assert(constructed:variant_name() == "Unit",
+    "Value was constructed incorrectly, expected constructed.variant to be Unit but got " .. constructed:variant_name())

assets/tests/construct/construct_tuple_struct.lua

@@ -1,7 +1,7 @@
 local type = world.get_type_by_name("SimpleTupleStruct")
 local constructed = construct(type, {
-    _1 = 123
+    ["1"] = 123
 })
 
-assert(constructed._1 == 123,
-    "Value was constructed incorrectly, expected constructed.foo to be 123 but got " .. constructed._1)
+assert(constructed[1] == 123,
+    "Value was constructed incorrectly, expected constructed.foo to be 123 but got " .. constructed[1])

assets/tests/construct/simple_enum.rhai

@@ -7,10 +7,10 @@ assert(constructed.variant_name.call() == "Struct", "Value was constructed incor
 assert(constructed.foo == 123, "Value was constructed incorrectly, expected constructed.foo to be 123 but got " + constructed.foo);
 
 // TupleStruct Variant
-constructed = construct.call(type, #{ variant: "TupleStruct", "_0": 123 });
+constructed = construct.call(type, #{ variant: "TupleStruct", "0": 123 });
 
 assert(constructed.variant_name.call() == "TupleStruct", "Value was constructed incorrectly, expected constructed.variant to be TupleStruct but got " + constructed.variant_name.call());
-assert(constructed["_0"] == 123, "Value was constructed incorrectly, expected constructed._0 to be 123 but got " + constructed["_0"]);
+assert(constructed[0] == 123, "Value was constructed incorrectly, expected constructed[0] to be 123 but got " + constructed[0]);
 
 // Unit Variant
 constructed = construct.call(type, #{ variant: "Unit" });

assets/tests/construct/simple_tuple_struct.rhai

@@ -1,4 +1,4 @@
 let type = world.get_type_by_name.call("SimpleTupleStruct");
-let constructed = construct.call(type, #{ "_0": 123 });
+let constructed = construct.call(type, #{ "0": 123 });
 
-assert(constructed["_0"] == 123, "Value was constructed incorrectly, expected constructed.foo to be 123 but got " + constructed["_0"]);
+assert(constructed[0] == 123, "Value was constructed incorrectly, expected constructed.foo to be 123 but got " + constructed[0]);

assets/tests/display/print_value_by_default.lua

@@ -20,9 +20,10 @@ local expected_vec3_debug = [[
             ReflectAllocationId(*anything*),
         ),
     },
-    reflect_path: ParsedPath(
-        [],
-    ),
+    reflect_path: ReferencePath {
+        one_indexed: false,
+        path: [],
+    },
 }
 ]]
 -- normalize allocation ids before comparison so tests don't fail on runtime-generated ids
@@ -49,9 +50,10 @@ ReflectReference {
             ),
         ),
     },
-    reflect_path: ParsedPath(
-        [],
-    ),
+    reflect_path: ReferencePath {
+        one_indexed: false,
+        path: [],
+    },
 }
 ]]
 

assets/tests/get_component/component_no_component_data.lua

@@ -3,4 +3,4 @@ local entity = world._get_entity_with_test_component("CompWithDefault")
 local retrieved = world.get_component(entity, component)
 
 assert(retrieved ~= nil, "Component was not found")
-assert(retrieved._1 == "Initial Value", "Component data was not retrieved correctly, retrieved._1 was: " .. retrieved._1)
+assert(retrieved[1] == "Initial Value", "Component data was not retrieved correctly, retrieved._1 was: " .. retrieved[1])