-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Name mixins and other exports of this addon #1357
Comments
Seems like a worthwhile addition. I'm not sure |
It's not quite public. Though others are using it as well: |
guess it's "intimate" API then 😉 So yeah, PR would be 👍 |
After talking to @rwjblue on Slack I'd consider wrapping these calls with the DEBUG flag described here: https://github.com/babel/ember-cli-babel#general-purpose-env-flags (and in his blog post here), making this only available in development. (Or maybe just a stripped down version described in this gist) |
Do not merge this yet, tests are missing. Re mainmatter#1357
Added names to mixins for Ember Inspector Re mainmatter#1357
This should actually be fixed in the Ember Inspector - see ember-cli/ember-rfc176-data#12 (comment) |
I work on large projects and more than often I find myself wading through a whole bunch of
UnknownMixin
and similar objects inside of Ember Inspector.We recently discovered that Ember Inspector reads the
[Ember.NAME_KEY]
property of each Ember Object to display a proper name.Therefore I propose to add this property to all mixins and objects exported by this addon, making the object stack a bit easier to read.
If this sounds interesting, I'll supply a pull request for this. 🙂
The text was updated successfully, but these errors were encountered: