Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function query_dns missing parameter #2466

Closed
kiekerjan opened this issue Dec 30, 2024 · 2 comments
Closed

Function query_dns missing parameter #2466

kiekerjan opened this issue Dec 30, 2024 · 2 comments

Comments

@kiekerjan
Copy link
Contributor

Pull request #2428 was merged last week.
Unfortunately, I made a mistake. It depends on pull request #2192 where the function query_dns was extended with parameter retry. Thus the function status_checks is borken (see https://discourse.mailinabox.email/t/every-day-at-1-20/12553)
I have updated branch https://github.com/kiekerjan/mailinabox/tree/ipv6spamhauscheck by removing the retry parameter. Another solution is to merge pull request 2192.
This needs to be fixed before a release, otherwise everyone gets broken stuff. Sorry...

@kiekerjan kiekerjan changed the title Query dns missing parameter Function query_dns missing parameter Dec 30, 2024
@yodax
Copy link
Contributor

yodax commented Dec 30, 2024

Ah that is what caused it. I had to fix it locally; didn’t have the time to fully dive into it and report back. 👍

@JoshData
Copy link
Member

JoshData commented Jan 4, 2025

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants