Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: zen-observable isn't supported #724

Closed
3 tasks done
1999 opened this issue Sep 11, 2024 · 5 comments · May be fixed by magidoc-org/magidoc#425
Closed
3 tasks done

[Bug]: zen-observable isn't supported #724

1999 opened this issue Sep 11, 2024 · 5 comments · May be fixed by magidoc-org/magidoc#425
Assignees
@cenk1cenk2
Labels
bug Something isn't working released

Comments

@1999
Copy link

1999 commented Sep 11, 2024

Replication of the Problem

export const foo: ListrTask = {
	title: 'Some random foo task',
	task: () =>
		new Observable((observer) => {
			observer.next('Foo');

			setTimeout(() => {
				observer.next('Bar');
			}, 2000);

			setTimeout(() => {
				console.log(observer);
				observer.complete();
			}, 10000);
		}),
};

Problem

It is said that listr2 supports Observable implementations like "rxjs" or "zen-observable" but it looks like these implementations differ. Only "rxjs" is working with listr2

Environment

osx
node 20

Log Output

No response

Preflight
@1999 1999 added the bug Something isn't working label Sep 11, 2024
@cenk1cenk2
Copy link
Collaborator

Dear @1999,

Thank you for reporting this, I did not specifically support the zen-observable but now it should be fixed.

A new version will publish soon.

cenk1cenk2 pushed a commit that referenced this issue Oct 3, 2024
chore(release): 8.2.5 [skip ci]
f325623 
## listr2 [8.2.5](https://github.com/listr2/listr2/compare/[email protected]@8.2.5) (2024-10-03)

### Bug Fixes

* ability to use zen-observable ([bae701b](bae701b)), closes [#724](#724)
@cenk1cenk2
Copy link
Collaborator

🎉 This issue has been resolved in version 8.2.5 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@cenk1cenk2
Copy link
Collaborator

🎉 This issue has been resolved in version 2.0.13 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@cenk1cenk2
Copy link
Collaborator

🎉 This issue has been resolved in version 2.0.12 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@cenk1cenk2
Copy link
Collaborator

🎉 This issue has been resolved in version 2.0.17 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

This was referenced Oct 18, 2024
Merged
Merged
@pelletier197 pelletier197 mentioned this issue Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cenk1cenk2 cenk1cenk2

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade listr2 from 8.2.4 to 8.2.5 magidoc-org/magidoc
2 participants
@1999 @cenk1cenk2