Skip to content

Commit 22209a9

Browse files
committed
chore: update progress notes
1 parent 6ac66b0 commit 22209a9

File tree

3 files changed

+15
-2
lines changed

3 files changed

+15
-2
lines changed

.github/workflows/ci-test-integration.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
on:
22
push:
3-
branches: [master, dev]
3+
branches: [master, dev, thlorenz/chainlink-ci]
44
pull_request:
55
types: [opened, reopened, synchronize, ready_for_review]
66

@@ -30,6 +30,8 @@ jobs:
3030
sudo prlimit --pid $$ --nofile=1048576:1048576
3131
sudo sysctl fs.inotify.max_user_instances=1280
3232
sudo sysctl fs.inotify.max_user_watches=655360
33-
make ci-test-integration
33+
(cd test-integration && make prep-chainlink-programs)
34+
ls -la test-integration/target/**/*
35+
# make -C test-integration test-chainlink
3436
shell: bash
3537
working-directory: magicblock-validator

test-integration/Makefile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ setup-schedulecommit-both:
5959
SETUP_ONLY=both \
6060
$(MAKE) test
6161

62+
prep-chainlink-programs:
63+
$(MAKE) chainlink-prep-programs -C ./test-chainlink
6264
test-chainlink:
6365
RUN_TESTS=chainlink \
6466
$(MAKE) test

test-integration/notes-babur.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,15 @@
2020
- [ ] magicblock-aperture/src/requests/http/get_fee_for_message.rs should check blockhash (Babur)
2121
- [ ] `self.blocks.contains(hash)` times out - noticed while investigating issue (Babur)
2222
- + why aren't we using that instead of `self.blocks.get(hash)`?
23+
- [ ] we won't know if an account delegated to system program is updated or undelegated, but I
24+
suppose that is ok since we treat them as isolated in our validator? (Gabriele)
25+
- [ ] ensure that we only unsubscribe when an account changes to delegated, _not_ when it
26+
previously was delegated to avoid
27+
1. have delegated account in our validator
28+
2. Commit acc
29+
3. Commit and undelegate -> turn on subscription
30+
4. Get update for 2. -> turn off subscription
31+
5. Never heaer about updates to that account again
2332

2433
## TODOs
2534

0 commit comments

Comments
 (0)