Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Change the ProductDetail query from url_key to id #2835

Open
8 tasks
lewisvoncken opened this issue Oct 27, 2020 · 1 comment
Open
8 tasks

[feature]: Change the ProductDetail query from url_key to id #2835

lewisvoncken opened this issue Oct 27, 2020 · 1 comment
Labels

Comments

@lewisvoncken
Copy link
Contributor

lewisvoncken commented Oct 27, 2020

Describe the solution you'd like
You do a Product search based on url_key but the url_key is already resolved and returns the actual product id so you can just retrieve the data for that specific product and not query on the url_key. This is also better for performance.

see for more info https://github.com/magento/pwa-studio/blob/develop/packages/venia-ui/lib/RootComponents/Product/product.js#L26

When the url_key is not searchable and you use the url_key to get the info of the current product, all the product detail pages will be the same

Please let us know what packages this feature is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa
@lewisvoncken lewisvoncken added the enhancement New feature or request label Oct 27, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 27, 2020

Hi @lewisvoncken. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant