Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement tabs in graphIQL playground #2829

Open
supernova-at opened this issue Oct 26, 2020 · 2 comments
Open

Implement tabs in graphIQL playground #2829

supernova-at opened this issue Oct 26, 2020 · 2 comments
Labels

Comments

@supernova-at
Copy link
Contributor

supernova-at commented Oct 26, 2020

The PWA Studio development web server also spawns a graphIQL playground for developers to investigate and issue GraphQL requests.

A recent PR (https://github.com/magento/pwa-studio/pull/2712/files#r499818792) removed the tabs in the graphIQL playground, as they were no longer straightforward to parse out of the codebase.

The ask here is to:

  1. Develop a strategy for which tabs we actually want to include. Note that it may not have to be "all GraphQL queries" as it was before
  2. Once a strategy is approved, implement that strategy in the codebase
@supernova-at supernova-at added the enhancement New feature or request label Oct 26, 2020
@m2-assistant
Copy link

m2-assistant bot commented Oct 26, 2020

Hi @supernova-at. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@sirugh
Copy link
Contributor

sirugh commented Oct 26, 2020

Adding some context here - one of the reasons we completely removed the tabs was because we moved from .graphql files composed of raw gql to .gql.js files which export template strings interpreted to gql via graphql-tag.

So one solution here may be to figure out how to have the graphiql playground understand the new files/syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants