Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instructions to add a custom component to the header component are unclear #2704

Open
acandael opened this issue Sep 14, 2020 · 8 comments
Open
Assignees
Labels
documentation This pertains to documentation. Progress: dev in progress

Comments

@acandael
Copy link

I'm going through the tutorial 'Manage component and application state' under 'PWA studio fundamentals'.

Currently I'm stuck a the section 'Add component to the storefront'. The instructions are not clear to me:

"Add this button to your application’s Header component using steps similar to the steps described in the Modify the site footer tutorial."

But at this point in the tutorial there is no Header component. So should I use the same steps from the footer tutorial to create the Header component? If that is the case, this won't work as the header component has not the same dependencies as the footer component.

I think this section would be improved, if it explains step by step what needs to happen, instead of refering to the footer tutorial.

@acandael acandael added the documentation This pertains to documentation. label Sep 14, 2020
@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2020

Hi @acandael. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@acandael
Copy link
Author

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Sep 19, 2020

Hi @acandael! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@acandael
Copy link
Author

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Sep 19, 2020

Hi @acandael! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@acandael
Copy link
Author

@magento add to contributors team

@jcalcaben jcalcaben assigned acandael and unassigned jcalcaben Feb 23, 2021
@levtronix
Copy link

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Jul 25, 2022

Hi @levtronix! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This pertains to documentation. Progress: dev in progress
Projects
None yet
Development

No branches or pull requests

3 participants