Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Region can be optional or required #2666

Open
8 tasks
sirugh opened this issue Aug 31, 2020 · 5 comments
Open
8 tasks

[feature]: Region can be optional or required #2666

sirugh opened this issue Aug 31, 2020 · 5 comments
Labels

Comments

@sirugh
Copy link
Contributor

sirugh commented Aug 31, 2020

Is your feature request related to a problem? Please describe.
The region input field is currently always required although some countries do not use them or require them.

#2659 (comment)

If someone wants to make the region field optional they have to duplicate the component just to remove the validate prop on the region field.

Describe the solution you'd like

  1. Allow for configuration to inform the UI whether region is required or not.
  2. Surface this configuration in a GQL query, probably the countries query

Describe alternatives you've considered

One alternative would be to remove the validate prop on the region field implementations. It would then fall to the user to submit the form to find out if the region is required or not. I would prefer not to do this.

Additional context

#2659 (comment)

Please let us know what packages this feature is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa
@sirugh sirugh added the enhancement New feature or request label Aug 31, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 31, 2020

Hi @sirugh. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@sirugh sirugh changed the title [feature]: Regions are not always required [feature]: Region can be optional or required Aug 31, 2020
@larsroettig
Copy link
Member

@sirugh i think we can close it rigth

@sirugh
Copy link
Contributor Author

sirugh commented Oct 22, 2020

@larsroettig why do you think that? Doesn't look like either of my proposed solutions have made it :P

@sirugh
Copy link
Contributor Author

sirugh commented May 17, 2021

@magento export issue to JIRA project PWA as Story

@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/PWA-1774 is successfully created for this GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants