You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
All PWA modules should be checked for consistency through a validation process.
This should work similarly to the Magento Coding Style an idea would be to build an eslint rule
Describe the solution you'd like
Idea we parse package.json check for "pwa-studio": {"targets": { "intercept" there
is defined if it is an PWA Extensions.
We add this folder to our validation process the every PWA Extensions need the esModules flag in the intercept file. Also we search if contains the module any .css or .graphql then flags cssModules flag or graphqlQueries flag are required.
I think what we also should check if a .js contains an import for @magento/peregrine but
is it is not defined as peerDependencies then we should throw an error for missing peer dependencies.
Describe alternatives you've considered
Additional context
Please let us know what packages this feature is in regards to:
venia-concept
venia-ui
pwa-buildpack
peregrine
pwa-devdocs
upward-js
upward-spec
create-pwa
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
All PWA modules should be checked for consistency through a validation process.
This should work similarly to the Magento Coding Style an idea would be to build an
eslint
ruleDescribe the solution you'd like
Idea we parse
package.json
check for"pwa-studio": {"targets": { "intercept"
thereis defined if it is an PWA Extensions.
We add this folder to our validation process the every PWA Extensions need the
esModules flag
in the intercept file. Also we search if contains the module any.css
or.graphql
then flagscssModules flag
orgraphqlQueries flag
are required.I think what we also should check if a
.js
contains an import for@magento/peregrine
butis it is not defined as
peerDependencies
then we should throw an error for missing peer dependencies.Describe alternatives you've considered
Additional context
Please let us know what packages this feature is in regards to:
venia-concept
venia-ui
pwa-buildpack
peregrine
pwa-devdocs
upward-js
upward-spec
create-pwa
The text was updated successfully, but these errors were encountered: