Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Unable to use my custom currency symbol #2491

Open
8 tasks
huykon opened this issue Jun 17, 2020 · 9 comments
Open
8 tasks

[feature]: Unable to use my custom currency symbol #2491

huykon opened this issue Jun 17, 2020 · 9 comments
Labels
enhancement New feature or request hold On hold until another condition is fulfilled. Priority: P3 Progress: ready for grooming Severity: S3

Comments

@huykon
Copy link
Contributor

huykon commented Jun 17, 2020

Describe the bug
When I tried to custom my currency symbol on frontend. It's working normally on Magento default but nothing change on PWA.

To reproduce
Steps to reproduce the behavior:

  1. Go to Magento admin > Stores > Currency > Currency Symbols
  2. Change currency symbol as you want (I tried ø ) then Click to Save currency symbols + Clear cache
  3. Go to Magento front page and see that applied
  4. Refresh + clear browser cache on PWA url but nothing applied.

Expected behavior
Show my custom currency symbol on PWA Venia theme.

Screenshots
My setting:

image

Display on Magento Luma:

image

Display on PWA Venia theme:

image

Please complete the following device information:

  • Device: Macbook Pro Mid 2014
  • OS : MacOS 10.14.6
  • Browser: Chrome, Safari
  • Browser Version [e.g. 22]:
  • Magento Version: 2.3.4
  • PWA Studio Version: 6.0
  • NPM version npm -v: 6.9.0
  • Node Version node -v: v10.16.0

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa
@huykon huykon added the bug Something isn't working label Jun 17, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 17, 2020

Hi @huykon. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@awilcoxa
Copy link

awilcoxa commented Jul 6, 2020

Created PWA-727 in internal Jira for grooming.

@huykon we'll provide additional feedback but just as an initial response, Venia currently doesn't fully support admin configuration/settings.

@awilcoxa
Copy link

Groomed with team and currently a low priority for core but willing to accept community contribution (or spike) to prove out feature request.

@awilcoxa awilcoxa changed the title [bug]: Unable to use my custom currency symbol [feature]: Unable to use my custom currency symbol Jul 13, 2020
@awilcoxa awilcoxa added enhancement New feature or request and removed bug Something isn't working labels Jul 13, 2020
@huykon huykon closed this as completed Jul 28, 2020
@huykon huykon reopened this Jul 28, 2020
@dani97
Copy link
Contributor

dani97 commented Dec 29, 2020

@magento I am working on this

@dani97
Copy link
Contributor

dani97 commented Dec 30, 2020

Lack of graphql support for currency symbol, we can fetch only shows symbol of default currency of the store and symbol of base currency. available_currency_codes field of Currency query should return symbol and code.

@dani97
Copy link
Contributor

dani97 commented Dec 30, 2020

magento/magento2#31494

@sirugh sirugh added the hold On hold until another condition is fulfilled. label Jan 26, 2021
@sirugh
Copy link
Contributor

sirugh commented Jan 26, 2021

Adding hold label until backend exposes this information.

@VijayKH
Copy link

VijayKH commented Dec 21, 2021

Hello Team,
Philippines currency symbol sign not showing in safari browser.
Its is showing price like PHP22.200.

Screenshot 2021-12-21 at 11 01 16 AM

Screenshot 2021-12-21 at 11 01 35 AM

Screenshot 2021-12-21 at 11 00 56 AM

Chrome Browser showing like this.
Screenshot 2021-12-21 at 11 05 45 AM

@sanganinamrata
Copy link
Member

@VijayKH I'm also facing the same issue since too long!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hold On hold until another condition is fulfilled. Priority: P3 Progress: ready for grooming Severity: S3
Projects
None yet
Development

No branches or pull requests

6 participants