-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug]: RootComponents can't have // commented code in their files #2239
Comments
@Jordaneisenburger I was just about to add some notes here. We hit the same bug around April and again in September, and needed @zetlen to lend an eye to understand it. It's the directive parser for root components that trips up expecting (if I recall correctly) a single comment block only which contains the "type" information. |
Created in Jira backlog for grooming/prioritization |
Marked as P3S3 given available workaround (@zetlen) |
@Jordaneisenburger can you confirm if this has been fixed in 8.0.0? Let's close if needed. Thanks! |
Looks like it's fixed, I'll close for now. |
I can confirm that this issue is not fixed. see # 2957 |
The issue doesn't seem to be resolved, we're running pwa studio 12.2 |
Describe the bug
Leaving code comments in RootComponents/Category/category.js prevents webpack from running after a restart
To reproduce
Steps to reproduce the behavior:
0. Start watcher with
yarn run watch:venia
if (totalPagesFromData === null) { return fullPageLoadingIndicator; }
with this//
comment style
6. Now go ahead and remove the piece of code that we've just commented. 7. Restart watcher and note it now work properlyExpected behavior
Run's without a problem when you comment code
Additional context
It seem sto happen when the code has an
if()
statement in the code that's been commented.Now for the weirdest part: when you use multiline comments like
/* */
the problem doesn't appear. So I think somewhere in the RootComponentsPlugin it somehow read's these commentsPlease complete the following device information:
npm -v
:node -v
:Please let us know what packages this bug is in regards to:
venia-concept
venia-ui
pwa-buildpack
peregrine
pwa-devdocs
upward-js
upward-spec
create-pwa
The text was updated successfully, but these errors were encountered: