Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new prototype feature to display social media icons with links #2154

Closed
wants to merge 6 commits into from

Conversation

LukasKiederle
Copy link
Contributor

@LukasKiederle LukasKiederle commented Feb 9, 2020

Description

I added a new component which currently takes its configuration from a util-class getMediaConfig. I implemented this because at some point the social media icons should be configured in magento and loaded over graphql. The implementation need for that is hard dependent on 2120.

The SocialMedia Icons have a feature toggle which can be used to either render them in the footer or not. Currently there is no feature to only display for example facebook and youtube only. If the feature is enabled it will display all 4 social media icons.

I also added the four icons for the social media platforms twitter, facebook, instagram and youtube. These icons are from https://feathericons.com/.

For testing purpose I added some jest tests.

Related Issue

Closes #2152 .

Acceptance

Verification Stakeholders

Specification

Verification Steps

  1. Go to the any page.
  2. Verify that by default social media icons are displayed like this:

social-media-icons

3. Every Icon should link to the specific social media homepage

Screenshots

Mobile

social-media-icons-mobile

Things to improve

  • Graphql Endpoint in Magento to get the configuration from the core_config_data table. (depends on [feature]: Proposal Refactoring for store configuration load #2120)
  • Build in a check to render a social media icon only if a link is configured in magento (currently all four icons are rendered all the time. Except if you disable the feature)

Checklist

  • I have updated the documentation accordingly, if necessary. (not necessary)
  • I have added tests to cover my changes, if necessary. (done)

@PWAStudioBot
Copy link
Contributor

PWAStudioBot commented Feb 9, 2020

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next nightly build run (assuming they are fixed).

Generated by 🚫 dangerJS against b1239b4

@LukasKiederle
Copy link
Contributor Author

LukasKiederle commented Feb 9, 2020

My local tests are not failing:

Test Suites: 253 passed, 253 total Tests: 5 skipped, 1268 passed, 1273 total Snapshots: 238 passed, 238 total Time: 69.742s, estimated 144s Ran all test suites in 7 projects.

Why is the testsuite failing?

@LukasKiederle
Copy link
Contributor Author

The problem was case sensitivity.

@larsroettig
Copy link
Member

@LukasKiederle I will write to you if possible to have own Extensions will archive this pr

@larsroettig larsroettig closed this May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature]: Render Social Media Icons in Footer with configurable href url
4 participants