Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Render Social Media Icons in Footer with configurable href url #2152

Open
2 of 8 tasks
LukasKiederle opened this issue Feb 8, 2020 · 3 comments
Open
2 of 8 tasks
Labels
enhancement New feature or request hold On hold until another condition is fulfilled. Progress: ready for grooming

Comments

@LukasKiederle
Copy link
Contributor

LukasKiederle commented Feb 8, 2020

Is your feature request related to a problem? Please describe.
At some point usually Magento Customers want Social Media icons to link their personal news-feeds on their page. In my experience this is most of the time displayed in the footer.

Describe the solution you'd like
I want to have a module which displays the most used Social Media icons (Instagram, Facebook, Twitter, Youtube) with a link to the news-feed of the customer.

The module handles:

  • which icons to display
  • which link is used for an icon

It gets its configuration from the magento instance with a graphql query out of the core_config_data.

Additional context

  • Extra (This is already being discussed in 2120)
    As far as I have looked into the footer functionality (getting the copyright from magento core_config_data-table over graphql), the function is not as generic as it could be. I would like to have a more generic version in scope of this ticket as well in order to allow future features to be build on top of this.

  • Screenshot

social-media-icons-footer

Please let us know what packages this feature is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa
@LukasKiederle LukasKiederle added the enhancement New feature or request label Feb 8, 2020
@LukasKiederle
Copy link
Contributor Author

I am currently working on a prototype for this.

LukasKiederle added a commit to LukasKiederle/pwa-studio that referenced this issue Feb 8, 2020
LukasKiederle added a commit to LukasKiederle/pwa-studio that referenced this issue Feb 9, 2020
LukasKiederle added a commit to LukasKiederle/pwa-studio that referenced this issue Feb 9, 2020
LukasKiederle added a commit to LukasKiederle/pwa-studio that referenced this issue Feb 9, 2020
@awilcoxa
Copy link

awilcoxa commented Mar 9, 2020

Created in Jira backlog PWA-382. During grooming, team determined that this is would be a great contribution for new extension model. @LukasKiederle we're currently working on publishing the new docs for extensions, once complete we'd like to work with you to convert into an extension.

For now, placing a "hold" on this issue.

@awilcoxa awilcoxa added the hold On hold until another condition is fulfilled. label Mar 9, 2020
@LukasKiederle
Copy link
Contributor Author

Ok, I will be patient :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hold On hold until another condition is fulfilled. Progress: ready for grooming
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants