-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature]: Render Social Media Icons in Footer with configurable href url #2152
Labels
enhancement
New feature or request
hold
On hold until another condition is fulfilled.
Progress: ready for grooming
Comments
I am currently working on a prototype for this. |
LukasKiederle
added a commit
to LukasKiederle/pwa-studio
that referenced
this issue
Feb 8, 2020
LukasKiederle
added a commit
to LukasKiederle/pwa-studio
that referenced
this issue
Feb 8, 2020
LukasKiederle
added a commit
to LukasKiederle/pwa-studio
that referenced
this issue
Feb 9, 2020
LukasKiederle
added a commit
to LukasKiederle/pwa-studio
that referenced
this issue
Feb 9, 2020
LukasKiederle
added a commit
to LukasKiederle/pwa-studio
that referenced
this issue
Feb 9, 2020
Created in Jira backlog PWA-382. During grooming, team determined that this is would be a great contribution for new extension model. @LukasKiederle we're currently working on publishing the new docs for extensions, once complete we'd like to work with you to convert into an extension. For now, placing a "hold" on this issue. |
Ok, I will be patient :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
hold
On hold until another condition is fulfilled.
Progress: ready for grooming
Is your feature request related to a problem? Please describe.
At some point usually Magento Customers want Social Media icons to link their personal news-feeds on their page. In my experience this is most of the time displayed in the footer.
Describe the solution you'd like
I want to have a module which displays the most used Social Media icons (Instagram, Facebook, Twitter, Youtube) with a link to the news-feed of the customer.
The module handles:
It gets its configuration from the magento instance with a graphql query out of the core_config_data.
Additional context
Extra (This is already being discussed in 2120)
As far as I have looked into the footer functionality (getting the copyright from magento core_config_data-table over graphql), the function is not as generic as it could be. I would like to have a more generic version in scope of this ticket as well in order to allow future features to be build on top of this.
Screenshot
Please let us know what packages this feature is in regards to:
venia-concept
venia-ui
pwa-buildpack
peregrine
pwa-devdocs
upward-js
upward-spec
create-pwa
The text was updated successfully, but these errors were encountered: